2021-01-25 13:10:26

by Zou Wei

Subject: [PATCH -next] kernel/sys.c: Remove unused including <linux/version.h>

Fix the following versioncheck warning:

kernel/sys.c:42:1: unused including <linux/version.h>

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
kernel/sys.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index e6fd8b8..8ecd3c5 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -39,7 +39,6 @@
#include <linux/mount.h>
#include <linux/gfp.h>
#include <linux/syscore_ops.h>
-#include <linux/version.h>
#include <linux/ctype.h>
#include <linux/syscall_user_dispatch.h>

--
2.6.2

2021-01-26 02:49:50

by Andrew Morton

Subject: Re: [PATCH -next] kernel/sys.c: Remove unused including <linux/version.h>

On Mon, 25 Jan 2021 20:47:49 +0800 Zou Wei <[email protected]> wrote:

> Fix the following versioncheck warning:
>
> kernel/sys.c:42:1: unused including <linux/version.h>
>
> ...
>
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -39,7 +39,6 @@
> #include <linux/mount.h>
> #include <linux/gfp.h>
> #include <linux/syscore_ops.h>
> -#include <linux/version.h>
> #include <linux/ctype.h>
> #include <linux/syscall_user_dispatch.h>
>

x86 allnoconfig:

kernel/sys.c: In function override_release:
kernel/sys.c:1244:7: error: LINUX_VERSION_PATCHLEVEL undeclared (first use in this function)
v = LINUX_VERSION_PATCHLEVEL + 60;
^~~~~~~~~~~~~~~~~~~~~~~~