2021-01-27 19:53:11

by Emil Renner Berthing

[permalink] [raw]
Subject: [PATCH] drm/i915/gt: use new tasklet API in execlist selftest

This converts the execlist selftest to use the new tasklet API in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

Signed-off-by: Emil Renner Berthing <[email protected]>
---
Hi Chris,

I seem to have missed some tasklist manipulation in the execlist
selftest. Feel free to squash this into my previous patch
("drm/i915/gt: use new tasklet API for execution list")
or leave it like this. Whatever is fine by me.

/Emil
---
drivers/gpu/drm/i915/gt/selftest_execlists.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 264b5ebdb021..ba55cd018f5b 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -609,7 +609,7 @@ static int live_hold_reset(void *arg)
}
tasklet_disable(&engine->execlists.tasklet);

- engine->execlists.tasklet.func(engine->execlists.tasklet.data);
+ engine->execlists.tasklet.callback(&engine->execlists.tasklet);
GEM_BUG_ON(execlists_active(&engine->execlists) != rq);

i915_request_get(rq);
@@ -4610,7 +4610,7 @@ static int reset_virtual_engine(struct intel_gt *gt,
}
tasklet_disable(&engine->execlists.tasklet);

- engine->execlists.tasklet.func(engine->execlists.tasklet.data);
+ engine->execlists.tasklet.callback(&engine->execlists.tasklet);
GEM_BUG_ON(execlists_active(&engine->execlists) != rq);

/* Fake a preemption event; failed of course */
--
2.30.0