2021-01-27 21:58:24

by Ts'o

Subject: [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT

struct setup_data.len is the length of data field. In case of
SETUP_INDIRECT, it should be sizeof(setup_indirect).

Signed-off-by: Cao jin <[email protected]>
---
Documentation/x86/boot.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/x86/boot.rst b/Documentation/x86/boot.rst
index abb9fc164657..fc844913dece 100644
--- a/Documentation/x86/boot.rst
+++ b/Documentation/x86/boot.rst
@@ -851,7 +851,7 @@ Protocol: 2.09+
struct setup_data {
__u64 next = 0 or <addr_of_next_setup_data_struct>;
__u32 type = SETUP_INDIRECT;
- __u32 len = sizeof(setup_data);
+ __u32 len = sizeof(setup_indirect);
__u8 data[sizeof(setup_indirect)] = struct setup_indirect {
__u32 type = SETUP_INDIRECT | SETUP_E820_EXT;
__u32 reserved = 0;
--
2.29.2

2021-01-27 23:59:18

by Daniel Kiper

Subject: Re: [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT

On Wed, Jan 27, 2021 at 04:49:11PM +0800, Cao jin wrote:
> struct setup_data.len is the length of data field. In case of
> SETUP_INDIRECT, it should be sizeof(setup_indirect).
>
> Signed-off-by: Cao jin <[email protected]>

Reviewed-by: Daniel Kiper <[email protected]>

Daniel

2021-01-28 22:29:05

by Jonathan Corbet

Subject: Re: [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT

On Wed, 27 Jan 2021 13:54:40 +0100
Daniel Kiper <[email protected]> wrote:

> On Wed, Jan 27, 2021 at 04:49:11PM +0800, Cao jin wrote:
> > struct setup_data.len is the length of data field. In case of
> > SETUP_INDIRECT, it should be sizeof(setup_indirect).
> >
> > Signed-off-by: Cao jin <[email protected]>
>
> Reviewed-by: Daniel Kiper <[email protected]>

Applied, thanks.

jon