2021-02-02 21:24:47

by 赵军奎

Subject: [PATCH] drm/msm: remove unneeded variable: "rc"

remove unneeded variable: "rc".

Signed-off-by: Bernard Zhao <[email protected]>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index d1780bcac8cc..9cc816663668 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -409,7 +409,6 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)

int dp_panel_init_panel_info(struct dp_panel *dp_panel)
{
- int rc = 0;
struct drm_display_mode *drm_mode;

drm_mode = &dp_panel->dp_mode.drm_mode;
@@ -436,7 +435,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel)
min_t(u32, dp_panel->dp_mode.bpp, 30));
DRM_DEBUG_DP("updated bpp = %d\n", dp_panel->dp_mode.bpp);

- return rc;
+ return 0;
}

struct dp_panel *dp_panel_get(struct dp_panel_in *in)
--
2.29.0

2021-02-02 23:04:24

by Guenter Roeck

Subject: Re: [PATCH] drm/msm: remove unneeded variable: "rc"

On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao <[email protected]> wrote:
>
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index d1780bcac8cc..9cc816663668 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -409,7 +409,6 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
>
> int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> {
> - int rc = 0;
> struct drm_display_mode *drm_mode;
>
> drm_mode = &dp_panel->dp_mode.drm_mode;
> @@ -436,7 +435,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> min_t(u32, dp_panel->dp_mode.bpp, 30));
> DRM_DEBUG_DP("updated bpp = %d\n", dp_panel->dp_mode.bpp);
>
> - return rc;
> + return 0;
> }
>
> struct dp_panel *dp_panel_get(struct dp_panel_in *in)
> --
> 2.29.0
>

2021-02-03 00:36:58

by Stephen Boyd

Subject: Re: [PATCH] drm/msm: remove unneeded variable: "rc"

Quoting Bernard Zhao (2021-02-02 04:32:03)
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>