2021-02-03 11:47:09

by Artem Bityutskiy

Subject: [PATCH] platform/x86/intel-uncore-freq: Add Sapphire Rapids server support

From: Artem Bityutskiy <[email protected]>

Sapphire Rapids uncore frequency control is the same as Skylake and Ice Lake.
Add the Sapphire Rapids CPU model number to the match array.

Signed-off-by: Artem Bityutskiy <[email protected]>
Reviewed-by: Tony Luck <[email protected]>
---
drivers/platform/x86/intel-uncore-frequency.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel-uncore-frequency.c b/drivers/platform/x86/intel-uncore-frequency.c
index 12d5ab7e1f5d..3ee4c5c8a64f 100644
--- a/drivers/platform/x86/intel-uncore-frequency.c
+++ b/drivers/platform/x86/intel-uncore-frequency.c
@@ -377,6 +377,7 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, NULL),
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
{}
};

--
2.26.2

2021-02-03 12:15:42

by Hans de Goede

Subject: Re: [PATCH] platform/x86/intel-uncore-freq: Add Sapphire Rapids server support

Hi,

On 2/3/21 12:43 PM, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <[email protected]>
>
> Sapphire Rapids uncore frequency control is the same as Skylake and Ice Lake.
> Add the Sapphire Rapids CPU model number to the match array.
>
> Signed-off-by: Artem Bityutskiy <[email protected]>
> Reviewed-by: Tony Luck <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> drivers/platform/x86/intel-uncore-frequency.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel-uncore-frequency.c b/drivers/platform/x86/intel-uncore-frequency.c
> index 12d5ab7e1f5d..3ee4c5c8a64f 100644
> --- a/drivers/platform/x86/intel-uncore-frequency.c
> +++ b/drivers/platform/x86/intel-uncore-frequency.c
> @@ -377,6 +377,7 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> {}
> };
>
>

2021-02-03 15:57:37

by srinivas pandruvada

Subject: Re: [PATCH] platform/x86/intel-uncore-freq: Add Sapphire Rapids server support

On Wed, 2021-02-03 at 13:43 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <[email protected]>
>
> Sapphire Rapids uncore frequency control is the same as Skylake and
> Ice Lake.
> Add the Sapphire Rapids CPU model number to the match array.
>
> Signed-off-by: Artem Bityutskiy <[email protected]>
> Reviewed-by: Tony Luck <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
> drivers/platform/x86/intel-uncore-frequency.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel-uncore-frequency.c
> b/drivers/platform/x86/intel-uncore-frequency.c
> index 12d5ab7e1f5d..3ee4c5c8a64f 100644
> --- a/drivers/platform/x86/intel-uncore-frequency.c
> +++ b/drivers/platform/x86/intel-uncore-frequency.c
> @@ -377,6 +377,7 @@ static const struct x86_cpu_id
> intel_uncore_cpu_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> {}
> };
>