2021-02-03 02:21:25

by Yang Li

Subject: [PATCH] octeontx2-af: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index e8fd712..0b6bf9f 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1323,7 +1323,7 @@ static int rvu_get_attach_blkaddr(struct rvu *rvu, int blktype,
break;
default:
return rvu_get_blkaddr(rvu, blktype, 0);
- };
+ }

if (is_block_implemented(rvu->hw, blkaddr))
return blkaddr;
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
index d27543c..b5b5032 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
@@ -1785,7 +1785,7 @@ static void rvu_dbg_npc_mcam_show_action(struct seq_file *s,
break;
default:
break;
- };
+ }
} else {
switch (rule->rx_action.op) {
case NIX_RX_ACTIONOP_DROP:
@@ -1806,7 +1806,7 @@ static void rvu_dbg_npc_mcam_show_action(struct seq_file *s,
break;
default:
break;
- };
+ }
}
}

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index 14832b6..f72c795 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -269,7 +269,7 @@ static void npc_scan_parse_result(struct npc_mcam *mcam, u8 bit_number,
break;
default:
return;
- };
+ }
npc_set_kw_masks(mcam, type, nr_bits, kwi, offset, intf);
}

--
1.8.3.1

2021-02-03 23:51:03

by Jesse Brandeburg

Subject: Re: [PATCH] octeontx2-af: remove unneeded semicolon

Yang Li wrote:

> Eliminate the following coccicheck warning:
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
> drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)

Trivial patch, recommend net-next as it's not a critical fix, Yang,
please include the targeted tree when sending like [PATCH net-next]

otherwise, for net-next:
Reviewed-by: Jesse Brandeburg <[email protected]>

2021-02-04 00:07:47

by Jakub Kicinski

Subject: Re: [PATCH] octeontx2-af: remove unneeded semicolon

On Wed, 3 Feb 2021 15:46:58 -0800 Jesse Brandeburg wrote:
> Yang Li wrote:
>
> > Eliminate the following coccicheck warning:
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
> > semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
> > ---
> > drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
> > drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
> > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> Trivial patch, recommend net-next as it's not a critical fix, Yang,
> please include the targeted tree when sending like [PATCH net-next]
>
> otherwise, for net-next:
> Reviewed-by: Jesse Brandeburg <[email protected]>

The patch does not apply to net-next, please rebase, add Jesse's review
tag and repost.