2021-02-05 14:00:14

by Nicolas Saenz Julienne

Subject: [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm,bcm2835-pm: Add support for bcm2711

Add a new compatible string for bcm2711 and the option to provide a
third reg property for the board's new Argon ASB.

The new Argon ASB took over V3D, which is our only consumer of this
driver so far. The old ASB is still be present with ISP and H264 bits
but no V3D.

Signed-off-by: Nicolas Saenz Julienne <[email protected]>
---
.../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
index 5e0555fc0666..a1f2e25e68db 100644
--- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
@@ -21,13 +21,14 @@ properties:
items:
- enum:
- brcm,bcm2835-pm
+ - brcm,bcm2711-pm
- const: brcm,bcm2835-pm-wdt

reg:
minItems: 1
- maxItems: 2
- description: Specifies base physical address and size of the two register
- ranges, "PM" and "ASYNC_BRIDGE" in that order.
+ maxItems: 3
+ description: Specifies base physical address and size of the register
+ ranges, "PM", "ASYNC_BRIDGE" and "ARGON_BRIDGE" in that order.

"#power-domain-cells":
const: 1
--
2.30.0

2021-02-06 11:40:28

by Stefan Wahren

Subject: Re: [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm,bcm2835-pm: Add support for bcm2711

Hi,

Am 05.02.21 um 14:52 schrieb Nicolas Saenz Julienne:
> Add a new compatible string for bcm2711 and the option to provide a
> third reg property for the board's new Argon ASB.
>
> The new Argon ASB took over V3D, which is our only consumer of this
> driver so far. The old ASB is still be present with ISP and H264 bits
> but no V3D.
>
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> ---
> .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> index 5e0555fc0666..a1f2e25e68db 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> @@ -21,13 +21,14 @@ properties:
> items:
> - enum:
> - brcm,bcm2835-pm
> + - brcm,bcm2711-pm
> - const: brcm,bcm2835-pm-wdt
>
> reg:
> minItems: 1
> - maxItems: 2
> - description: Specifies base physical address and size of the two register
> - ranges, "PM" and "ASYNC_BRIDGE" in that order.
> + maxItems: 3
> + description: Specifies base physical address and size of the register
> + ranges, "PM", "ASYNC_BRIDGE" and "ARGON_BRIDGE" in that order.
i know it's not trivial, but maybe we have reached the point to
introduce reg-names here.
>
> "#power-domain-cells":
> const: 1