2021-02-08 14:47:43

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] PCI: mobiveil: Improve PCIE_LAYERSCAPE_GEN4 dependencies

- Drop the dependency on PCI, as this is implied by the dependency on
PCI_MSI_IRQ_DOMAIN,
- Drop the dependencies on OF and ARM64, as the driver compiles fine
without OF and/or on other architectures,
- The Freescale Layerscape PCIe Gen4 controller is present only on
Freescale Layerscape SoCs. Hence depend on ARCH_LAYERSCAPE, to
prevent asking the user about this driver when configuring a kernel
without Freescale Layerscape support, unless compile-testing.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/pci/controller/mobiveil/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
index a62d247018cf6b51..e4643fb94e78f3da 100644
--- a/drivers/pci/controller/mobiveil/Kconfig
+++ b/drivers/pci/controller/mobiveil/Kconfig
@@ -24,8 +24,7 @@ config PCIE_MOBIVEIL_PLAT

config PCIE_LAYERSCAPE_GEN4
bool "Freescale Layerscape PCIe Gen4 controller"
- depends on PCI
- depends on OF && (ARM64 || ARCH_LAYERSCAPE)
+ depends on ARCH_LAYERSCAPE || COMPILE_TEST
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_MOBIVEIL_HOST
help
--
2.25.1


2021-03-23 10:32:19

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI: mobiveil: Improve PCIE_LAYERSCAPE_GEN4 dependencies

On Mon, 8 Feb 2021 15:23:01 +0100, Geert Uytterhoeven wrote:
> - Drop the dependency on PCI, as this is implied by the dependency on
> PCI_MSI_IRQ_DOMAIN,
> - Drop the dependencies on OF and ARM64, as the driver compiles fine
> without OF and/or on other architectures,
> - The Freescale Layerscape PCIe Gen4 controller is present only on
> Freescale Layerscape SoCs. Hence depend on ARCH_LAYERSCAPE, to
> prevent asking the user about this driver when configuring a kernel
> without Freescale Layerscape support, unless compile-testing.

Applied to pci/misc, thanks!

[1/1] PCI: mobiveil: Improve PCIE_LAYERSCAPE_GEN4 dependencies
https://git.kernel.org/lpieralisi/pci/c/021a90fe60

Thanks,
Lorenzo