2021-02-08 15:16:00

by Geert Uytterhoeven

Subject: [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally

Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of ARMADA375_USBCLUSTER_PHY
to MACH_ARMADA_375, and ask the user in case of compile-testing.

Fixes: eee47538ec1f2619 ("phy: add support for USB cluster on the Armada 375 SoC")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/phy/marvell/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig
index 6c96f2bf52665789..c8ee23fc3a83d360 100644
--- a/drivers/phy/marvell/Kconfig
+++ b/drivers/phy/marvell/Kconfig
@@ -3,8 +3,8 @@
# Phy drivers for Marvell platforms
#
config ARMADA375_USBCLUSTER_PHY
- def_bool y
- depends on MACH_ARMADA_375 || COMPILE_TEST
+ bool "Armada 375 USB cluster PHY support" if COMPILE_TEST
+ default y if MACH_ARMADA_375
depends on OF && HAS_IOMEM
select GENERIC_PHY

--
2.25.1

2021-03-15 10:01:07

by Vinod Koul

Subject: Re: [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally

On 08-02-21, 16:02, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of ARMADA375_USBCLUSTER_PHY
> to MACH_ARMADA_375, and ask the user in case of compile-testing.

Applied, thanks

--
~Vinod