2021-02-10 02:05:11

by Paul Gortmaker

Subject: [PATCH 2/8] lib: test_bitmap: add tests to trigger ERANGE case.

Add tests that specify a valid range, but one that is outside the
width of the bitmap for which it is to be applied to. These should
trigger an -ERANGE response from the code.

Cc: Yury Norov <[email protected]>
Cc: Rasmus Villemoes <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
---
lib/test_bitmap.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 589f2a34ceba..172ffbfa83c4 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -338,6 +338,8 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
{-EINVAL, "-1", NULL, 8, 0},
{-EINVAL, "-0", NULL, 8, 0},
{-EINVAL, "10-1", NULL, 8, 0},
+ {-ERANGE, "8-8", NULL, 8, 0},
+ {-ERANGE, "0-31", NULL, 8, 0},
{-EINVAL, "0-31:", NULL, 32, 0},
{-EINVAL, "0-31:0", NULL, 32, 0},
{-EINVAL, "0-31:0/", NULL, 32, 0},
--
2.17.1

2021-02-10 16:30:41

by Andy Shevchenko

Subject: Re: [PATCH 2/8] lib: test_bitmap: add tests to trigger ERANGE case.

On Tue, Feb 09, 2021 at 05:59:01PM -0500, Paul Gortmaker wrote:
> Add tests that specify a valid range, but one that is outside the
> width of the bitmap for which it is to be applied to. These should
> trigger an -ERANGE response from the code.

Reviewed-by: Andy Shevchenko <[email protected]>

> Cc: Yury Norov <[email protected]>
> Cc: Rasmus Villemoes <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Signed-off-by: Paul Gortmaker <[email protected]>
> ---
> lib/test_bitmap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 589f2a34ceba..172ffbfa83c4 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -338,6 +338,8 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> {-EINVAL, "-1", NULL, 8, 0},
> {-EINVAL, "-0", NULL, 8, 0},
> {-EINVAL, "10-1", NULL, 8, 0},
> + {-ERANGE, "8-8", NULL, 8, 0},
> + {-ERANGE, "0-31", NULL, 8, 0},
> {-EINVAL, "0-31:", NULL, 32, 0},
> {-EINVAL, "0-31:0", NULL, 32, 0},
> {-EINVAL, "0-31:0/", NULL, 32, 0},
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko