2021-02-10 10:56:36

by Alexandru Ardelean

Subject: [PATCH] iio: adc: adi-axi-adc: add proper Kconfig dependencies

The ADI AXI ADC driver requires IO mem access and OF to work. This change
adds these dependencies to the Kconfig symbol of the driver.

This was also found via the lkp bot, as the
devm_platform_ioremap_resource() symbol was not found at link-time on the
S390 architecture.

Fixes: ef04070692a21 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Alexandru Ardelean <[email protected]>
---
drivers/iio/adc/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 769381b05b9a..d20a3b574af9 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -266,6 +266,8 @@ config ADI_AXI_ADC
select IIO_BUFFER
select IIO_BUFFER_HW_CONSUMER
select IIO_BUFFER_DMAENGINE
+ depends on HAS_IOMEM
+ depends on OF
help
Say yes here to build support for Analog Devices Generic
AXI ADC IP core. The IP core is used for interfacing with
--
2.17.1

2021-02-14 12:45:27

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: adi-axi-adc: add proper Kconfig dependencies

On Wed, 10 Feb 2021 12:50:44 +0200
Alexandru Ardelean <[email protected]> wrote:

> The ADI AXI ADC driver requires IO mem access and OF to work. This change
> adds these dependencies to the Kconfig symbol of the driver.
>
> This was also found via the lkp bot, as the
> devm_platform_ioremap_resource() symbol was not found at link-time on the
> S390 architecture.
>
> Fixes: ef04070692a21 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Alexandru Ardelean <[email protected]>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
> drivers/iio/adc/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 769381b05b9a..d20a3b574af9 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -266,6 +266,8 @@ config ADI_AXI_ADC
> select IIO_BUFFER
> select IIO_BUFFER_HW_CONSUMER
> select IIO_BUFFER_DMAENGINE
> + depends on HAS_IOMEM
> + depends on OF
> help
> Say yes here to build support for Analog Devices Generic
> AXI ADC IP core. The IP core is used for interfacing with