2021-02-10 23:55:02

by Joel Stanley

[permalink] [raw]
Subject: [PATCH] ARM: kexec: Remove unused kexec_reinit callback

The last (only?) user of this was removed in commit ba364fc752da ("ARM:
Kirkwood: Remove mach-kirkwood"), back in v3.17.

Signed-off-by: Joel Stanley <[email protected]>
---
arch/arm/include/asm/kexec.h | 3 ---
arch/arm/kernel/machine_kexec.c | 8 --------
2 files changed, 11 deletions(-)

diff --git a/arch/arm/include/asm/kexec.h b/arch/arm/include/asm/kexec.h
index 22751b5b5735..e62832dcba76 100644
--- a/arch/arm/include/asm/kexec.h
+++ b/arch/arm/include/asm/kexec.h
@@ -56,9 +56,6 @@ static inline void crash_setup_regs(struct pt_regs *newregs,
}
}

-/* Function pointer to optional machine-specific reinitialization */
-extern void (*kexec_reinit)(void);
-
static inline unsigned long phys_to_boot_phys(phys_addr_t phys)
{
return phys_to_idmap(phys);
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index 2b09dad7935e..f567032a09c0 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -147,11 +147,6 @@ void machine_crash_shutdown(struct pt_regs *regs)
pr_info("Loading crashdump kernel...\n");
}

-/*
- * Function pointer to optional machine-specific reinitialization
- */
-void (*kexec_reinit)(void);
-
void machine_kexec(struct kimage *image)
{
unsigned long page_list, reboot_entry_phys;
@@ -187,9 +182,6 @@ void machine_kexec(struct kimage *image)

pr_info("Bye!\n");

- if (kexec_reinit)
- kexec_reinit();
-
soft_restart(reboot_entry_phys);
}

--
2.30.0


2021-02-11 07:36:44

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ARM: kexec: Remove unused kexec_reinit callback

On Thu, Feb 11, 2021 at 12:52 AM Joel Stanley <[email protected]> wrote:
>
> The last (only?) user of this was removed in commit ba364fc752da ("ARM:
> Kirkwood: Remove mach-kirkwood"), back in v3.17.
>
> Signed-off-by: Joel Stanley <[email protected]>

Reviewed-by: Arnd Bergmann <[email protected]>