2021-02-11 16:46:39

by Pritthijit Nath

Subject: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c

This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
In addition the misspelling of "transferred" also has been fixed.

Signed-off-by: Pritthijit Nath <[email protected]>
---
drivers/staging/greybus/hid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index ed706f39e87a..adb91286803a 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
}

static int __gb_hid_get_raw_report(struct hid_device *hid,
- unsigned char report_number, __u8 *buf, size_t count,
- unsigned char report_type)
+ unsigned char report_number, __u8 *buf, size_t count,
+ unsigned char report_type)
{
struct gb_hid *ghid = hid->driver_data;
int ret;
@@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,

ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
if (report_id && ret >= 0)
- ret++; /* add report_id to the number of transfered bytes */
+ ret++; /* add report_id to the number of transferred bytes */

return 0;
}
--
2.25.1

2021-02-11 20:34:02

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c

On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
> In addition the misspelling of "transferred" also has been fixed.

When you say "also" or "in addition" in a changelog, that is a huge hint
that this needs to be broken up into multiple patches.

Please do so, and fix your changelog ling length and send this as a
patch series.

thanks,

greg k-h