LinuxLists.cc - drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to

2021-02-11 14:23:03

Subject: drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to_phys'

tree: # git checkout 4bfc848e0981fcd35db00fe1c6581560689f6dc7
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
If you fix the issue, kindly add following tag as appropriate
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
enable use of generic memory_model.h for !DISCONTIGMEM
/> l/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
el/git/torvalds/linux.git/commit/?id=4bfc848e0981fcd35db00fe1c6581560689f6dc7">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4bfc848e0981fcd35db00fe1c6581560689f6dc7
/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
/> make.cross ARCH=m68k
/> ection#4d6b21397621263d0d2423392821632e22206b2a3976"><[email protected]>
In function 'vb2_dc_get_userptr':
error: implicit declaration of function '__pfn_to_phys' [-Werror=implicit-function-declaration]
0);
buf2-dma-contig.c
Tomasz Stanislawski 2012-06-14 455
Hans Verkuil 2016-04-15 456 static void *vb2_dc_get_userptr(struct device *dev, unsigned long vaddr,
Hans Verkuil 2014-11-18 457 unsigned long size, enum dma_data_direction dma_dir)
Pawel Osciak 2010-10-11 458 {
Pawel Osciak 2010-10-11 459 struct vb2_dc_buf *buf;
Jan Kara 2015-07-13 460 struct frame_vector *vec;
Tvrtko Ursulin 2017-07-31 461 unsigned int offset;
Jan Kara 2015-07-13 462 int n_pages, i;
Tomasz Stanislawski 2012-06-14 463 int ret = 0;
Tomasz Stanislawski 2012-06-14 464 struct sg_table *sgt;
Tomasz Stanislawski 2012-06-14 465 unsigned long contig_size;
Marek Szyprowski 2012-06-12 466 unsigned long dma_align = dma_get_cache_alignment();
Marek Szyprowski 2012-06-12 467
Marek Szyprowski 2012-06-12 468 /* Only cache aligned DMA transfers are reliable */
Marek Szyprowski 2012-06-12 469 if (!IS_ALIGNED(vaddr | size, dma_align)) {
Marek Szyprowski 2012-06-12 470 pr_debug("user data must be aligned to %lu bytes\n", dma_align);
Marek Szyprowski 2012-06-12 471 return ERR_PTR(-EINVAL);
Marek Szyprowski 2012-06-12 472 }
Marek Szyprowski 2012-06-12 473
Marek Szyprowski 2012-06-12 474 if (!size) {
Marek Szyprowski 2012-06-12 475 pr_debug("size is zero\n");
Marek Szyprowski 2012-06-12 476 return ERR_PTR(-EINVAL);
Marek Szyprowski 2012-06-12 477 }
Pawel Osciak 2010-10-11 478
Hans Verkuil 2016-07-21 479 if (WARN_ON(!dev))
Hans Verkuil 2016-07-21 480 return ERR_PTR(-EINVAL);
Hans Verkuil 2016-07-21 481
Pawel Osciak 2010-10-11 482 buf = kzalloc(sizeof *buf, GFP_KERNEL);
Pawel Osciak 2010-10-11 483 if (!buf)
Pawel Osciak 2010-10-11 484 return ERR_PTR(-ENOMEM);
Pawel Osciak 2010-10-11 485
Hans Verkuil 2016-04-15 486 buf->dev = dev;
Hans Verkuil 2014-11-18 487 buf->dma_dir = dma_dir;
Tomasz Stanislawski 2012-06-14 488
Tvrtko Ursulin 2017-07-31 489 offset = lower_32_bits(offset_in_page(vaddr));
Hans Verkuil 2019-04-04 490 vec = vb2_create_framevec(vaddr, size);
Jan Kara 2015-07-13 491 if (IS_ERR(vec)) {
Jan Kara 2015-07-13 492 ret = PTR_ERR(vec);
Tomasz Stanislawski 2012-06-14 493 goto fail_buf;
Tomasz Stanislawski 2012-06-14 494 }
Jan Kara 2015-07-13 495 buf->vec = vec;
Jan Kara 2015-07-13 496 n_pages = frame_vector_count(vec);
Jan Kara 2015-07-13 497 ret = frame_vector_to_pages(vec);
Jan Kara 2015-07-13 498 if (ret < 0) {
Jan Kara 2015-07-13 499 unsigned long *nums = frame_vector_pfns(vec);
Tomasz Stanislawski 2012-06-14 500
Jan Kara 2015-07-13 501 /*
Jan Kara 2015-07-13 502 * Failed to convert to pages... Check the memory is physically
Jan Kara 2015-07-13 503 * contiguous and use direct mapping
Jan Kara 2015-07-13 504 */
Jan Kara 2015-07-13 505 for (i = 1; i < n_pages; i++)
Jan Kara 2015-07-13 506 if (nums[i-1] + 1 != nums[i])
Jan Kara 2015-07-13 507 goto fail_pfnvec;
Christoph Hellwig 2019-01-04 508 buf->dma_addr = dma_map_resource(buf->dev,
Christoph Hellwig 2019-01-04 @509 __pfn_to_phys(nums[0]), size, buf->dma_dir, 0);
Christoph Hellwig 2019-01-04 510 if (dma_mapping_error(buf->dev, buf->dma_addr)) {
Christoph Hellwig 2019-01-04 511 ret = -ENOMEM;
Christoph Hellwig 2019-01-04 512 goto fail_pfnvec;
Christoph Hellwig 2019-01-04 513 }
Jan Kara 2015-07-13 514 goto out;
Tomasz Stanislawski 2012-06-14 515 }
Tomasz Stanislawski 2012-06-14 516
Tomasz Stanislawski 2012-06-14 517 sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
Tomasz Stanislawski 2012-06-14 518 if (!sgt) {
Tomasz Stanislawski 2012-06-14 519 pr_err("failed to allocate sg table\n");
Tomasz Stanislawski 2012-06-14 520 ret = -ENOMEM;
Jan Kara 2015-07-13 521 goto fail_pfnvec;
Pawel Osciak 2010-10-11 522 }
Pawel Osciak 2010-10-11 523
Jan Kara 2015-07-13 524 ret = sg_alloc_table_from_pages(sgt, frame_vector_pages(vec), n_pages,
Tomasz Stanislawski 2012-06-14 525 offset, size, GFP_KERNEL);
Tomasz Stanislawski 2012-06-14 526 if (ret) {
Tomasz Stanislawski 2012-06-14 527 pr_err("failed to initialize sg table\n");
Tomasz Stanislawski 2012-06-14 528 goto fail_sgt;
Tomasz Stanislawski 2012-06-14 529 }
Tomasz Stanislawski 2012-06-14 530
Hans Verkuil 2014-11-18 531 /*
Hans Verkuil 2014-11-18 532 * No need to sync to the device, this will happen later when the
Hans Verkuil 2014-11-18 533 * prepare() memop is called.
Hans Verkuil 2014-11-18 534 */
Marek Szyprowski 2020-09-04 535 if (dma_map_sgtable(buf->dev, sgt, buf->dma_dir,
Marek Szyprowski 2020-09-04 536 DMA_ATTR_SKIP_CPU_SYNC)) {
Tomasz Stanislawski 2012-06-14 537 pr_err("failed to map scatterlist\n");
Tomasz Stanislawski 2012-06-14 538 ret = -EIO;
Tomasz Stanislawski 2012-06-14 539 goto fail_sgt_init;
Tomasz Stanislawski 2012-06-14 540 }
Tomasz Stanislawski 2012-06-14 541
Tomasz Stanislawski 2012-06-14 542 contig_size = vb2_dc_get_contiguous_size(sgt);
Tomasz Stanislawski 2012-06-14 543 if (contig_size < size) {
Tomasz Stanislawski 2012-06-14 544 pr_err("contiguous mapping is too small %lu/%lu\n",
Tomasz Stanislawski 2012-06-14 545 contig_size, size);
Tomasz Stanislawski 2012-06-14 546 ret = -EFAULT;
Tomasz Stanislawski 2012-06-14 547 goto fail_map_sg;
Tomasz Stanislawski 2012-06-14 548 }
Tomasz Stanislawski 2012-06-14 549
Tomasz Stanislawski 2012-06-14 550 buf->dma_addr = sg_dma_address(sgt->sgl);
Tomasz Stanislawski 2012-06-14 551 buf->dma_sgt = sgt;
Jan Kara 2015-07-13 552 out:
Jan Kara 2015-07-13 553 buf->size = size;
Pawel Osciak 2010-10-11 554
Pawel Osciak 2010-10-11 555 return buf;
Pawel Osciak 2010-10-11 556
Tomasz Stanislawski 2012-06-14 557 fail_map_sg:
Marek Szyprowski 2020-09-04 558 dma_unmap_sgtable(buf->dev, sgt, buf->dma_dir, DMA_ATTR_SKIP_CPU_SYNC);
Pawel Osciak 2010-10-11 559
Tomasz Stanislawski 2012-06-14 560 fail_sgt_init:
Tomasz Stanislawski 2012-06-14 561 sg_free_table(sgt);
Tomasz Stanislawski 2012-06-14 562
Tomasz Stanislawski 2012-06-14 563 fail_sgt:
Tomasz Stanislawski 2012-06-14 564 kfree(sgt);
Tomasz Stanislawski 2012-06-14 565
Jan Kara 2015-07-13 566 fail_pfnvec:
Jan Kara 2015-07-13 567 vb2_destroy_framevec(vec);
Tomasz Stanislawski 2012-06-14 568
Tomasz Stanislawski 2012-06-14 569 fail_buf:
Pawel Osciak 2010-10-11 570 kfree(buf);
Tomasz Stanislawski 2012-06-14 571
Tomasz Stanislawski 2012-06-14 572 return ERR_PTR(ret);
Pawel Osciak 2010-10-11 573 }
Pawel Osciak 2010-10-11 574
commit
replace a layering violation with dma_map_resource
tion#71571d054a191219311d02055f15145716054a"><[email protected]>
tion#cdeba1b9f6a5aea58da1beb9e3a9a8ebaab9f6"><[email protected]>
ts.01.org">https://lists.01.org/hyperkitty/list/[email protected]

Attachments:

(No filename) (17.08 kB)
.config.gz (25.41 kB)
Download all attachments

2021-02-12 00:36:26

by Mike Rapoport

[permalink] [raw]

Subject: Re: drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to_phys'

On Thu, Feb 11, 2021 at 10:03:54PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 291009f656e8eaebbdfd3a8d99f6b190a9ce9deb
> commit: 4bfc848e0981fcd35db00fe1c6581560689f6dc7 m68k/mm: enable use of generic memory_model.h for !DISCONTIGMEM
> date: 8 weeks ago
> config: m68k-randconfig-r021-20210211 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4bfc848e0981fcd35db00fe1c6581560689f6dc7
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 4bfc848e0981fcd35db00fe1c6581560689f6dc7
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> drivers/media/common/videobuf2/videobuf2-dma-contig.c: In function 'vb2_dc_get_userptr':
> >> drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to_phys' [-Werror=implicit-function-declaration]
> 509 | __pfn_to_phys(nums[0]), size, buf->dma_dir, 0);
> | ^~~~~~~~~~~~~
> cc1: some warnings being treated as errors

Here is the fix:

From 9709296dbfb627b99defc2c152e1b2d264cf5b86 Mon Sep 17 00:00:00 2001
From: Mike Rapoport <[email protected]>
Date: Fri, 12 Feb 2021 01:12:15 +0200
Subject: [PATCH] m68k: make __pfn_to_phys() and __phys_to_pfn() available for !MMU

Recent changes that obsoleted DISCONTIGMEM on m68k switched the MMU variant
to use generic definitions of __pfn_to_phys() and __phys_to_pfn(), but
missed the !MMU variant which caused a build failure:

All errors (new ones prefixed by >>):

drivers/media/common/videobuf2/videobuf2-dma-contig.c: In function 'vb2_dc_get_userptr':
>> drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to_phys' [-Werror=implicit-function-declaration]
509 | __pfn_to_phys(nums[0]), size, buf->dma_dir, 0);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors

Enable __pfn_to_phys() and __phys_to_pfn() on !MMU builds.

Fixes: 4bfc848e0981 ("m68k/mm: enable use of generic memory_model.h for !DISCONTIGMEM")
Signed-off-by: Mike Rapoport <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
arch/m68k/include/asm/page.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
index 6116d7094292..97087dd3ca6d 100644
--- a/arch/m68k/include/asm/page.h
+++ b/arch/m68k/include/asm/page.h
@@ -62,7 +62,7 @@ extern unsigned long _ramend;
#include <asm/page_no.h>
#endif

-#ifdef CONFIG_DISCONTIGMEM
+#if !defined(CONFIG_MMU) || defined(CONFIG_DISCONTIGMEM)
#define __phys_to_pfn(paddr) ((unsigned long)((paddr) >> PAGE_SHIFT))
#define __pfn_to_phys(pfn) PFN_PHYS(pfn)
#endif
--
2.28.0