2021-02-12 13:24:10

by Nobuhiro Iwamatsu

Subject: [PATCH v2 1/2] dt-bindings: pwm: Add bindings for Toshiba Visconti PWM Controller

Add bindings for the Toshiba Visconti PWM Controller.

Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
---
.../bindings/pwm/toshiba,pwm-visconti.yaml | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml

diff --git a/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
new file mode 100644
index 000000000000..f11558cdc32f
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/toshiba,pwm-visconti.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba Visconti PWM Controller
+
+maintainers:
+ - Nobuhiro Iwamatsu <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: toshiba,pwm-visconti
+
+ reg:
+ maxItems: 1
+
+ '#pwm-cells':
+ const: 2
+
+required:
+ - compatible
+ - reg
+ - '#pwm-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ pwm: pwm@241c0000 {
+ compatible = "toshiba,pwm-visconti";
+ reg = <0 0x241c0000 0 0x1000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm_mux>;
+ #pwm-cells = <2>;
+ };
+ };
--
2.30.0.rc2

2021-03-05 20:27:48

by Rob Herring (Arm)

Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Add bindings for Toshiba Visconti PWM Controller

On Fri, Feb 12, 2021 at 10:19:09PM +0900, Nobuhiro Iwamatsu wrote:
> Add bindings for the Toshiba Visconti PWM Controller.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> ---
> .../bindings/pwm/toshiba,pwm-visconti.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
> new file mode 100644
> index 000000000000..f11558cdc32f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/toshiba,pwm-visconti.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba Visconti PWM Controller
> +
> +maintainers:
> + - Nobuhiro Iwamatsu <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - const: toshiba,pwm-visconti

The 'normal' order is: toshiba,visconti-pwm

Otherwise,

Reviewed-by: Rob Herring <[email protected]>

> +
> + reg:
> + maxItems: 1
> +
> + '#pwm-cells':
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - '#pwm-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + pwm: pwm@241c0000 {
> + compatible = "toshiba,pwm-visconti";
> + reg = <0 0x241c0000 0 0x1000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm_mux>;
> + #pwm-cells = <2>;
> + };
> + };
> --
> 2.30.0.rc2
>

2021-04-09 07:46:41

by Nobuhiro Iwamatsu

Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Add bindings for Toshiba Visconti PWM Controller

Hi,

On Fri, Mar 05, 2021 at 02:22:24PM -0600, Rob Herring wrote:
> On Fri, Feb 12, 2021 at 10:19:09PM +0900, Nobuhiro Iwamatsu wrote:
> > Add bindings for the Toshiba Visconti PWM Controller.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> > ---
> > .../bindings/pwm/toshiba,pwm-visconti.yaml | 43 +++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
> > new file mode 100644
> > index 000000000000..f11558cdc32f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/toshiba,pwm-visconti.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti PWM Controller
> > +
> > +maintainers:
> > + - Nobuhiro Iwamatsu <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - const: toshiba,pwm-visconti
>
> The 'normal' order is: toshiba,visconti-pwm

I see, I will change to it.

>
> Otherwise,
>
> Reviewed-by: Rob Herring <[email protected]>
>

Thanks!

Best regards,
Nobuhiro