2021-02-12 22:29:38

by mark gross

[permalink] [raw]
Subject: [PATCH v6 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings

From: Daniele Alessandrelli <[email protected]>

Add bindings for the Intel VPU IPC mailbox driver.

Cc: Rob Herring <[email protected]>
Cc: [email protected]
Signed-off-by: Daniele Alessandrelli <[email protected]>
Signed-off-by: Mark Gross <[email protected]>
---
.../mailbox/intel,vpu-ipc-mailbox.yaml | 69 +++++++++++++++++++
MAINTAINERS | 6 ++
2 files changed, 75 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml

diff --git a/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
new file mode 100644
index 000000000000..923a6d619a64
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2020 Intel Corporation
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/mailbox/intel,vpu-ipc-mailbox.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Intel VPU IPC mailbox
+
+maintainers:
+ - Daniele Alessandrelli <[email protected]>
+
+description: |
+ Intel VPU SoCs like Keem Bay have hardware FIFOs to enable Inter-Processor
+ Communication (IPC) between the CPU and the VPU.
+
+ Specifically, there is one HW FIFO for the CPU (aka Application Processor -
+ AP) and one for the VPU. Each FIFO can hold 128 entries of 32 bits each. A
+ "FIFO-not-empty" interrupt is raised every time there is at least a message
+ in the FIFO. The CPU FIFO raises interrupts to the CPU, while the VPU FIFO
+ raises interrupts to VPU. When the CPU wants to send a message to the VPU it
+ writes to the VPU FIFO, similarly, when the VPU want to send a message to the
+ CPU, it writes to the CPU FIFO.
+
+ Refer to ./mailbox.txt for generic information about mailbox device-tree
+ bindings.
+
+properties:
+ compatible:
+ const: intel,vpu-ipc-mailbox
+
+ reg:
+ items:
+ - description: The CPU FIFO registers
+ - description: The VPU FIFO registers
+
+ reg-names:
+ items:
+ - const: cpu_fifo
+ - const: vpu_fifo
+
+ interrupts:
+ items:
+ - description: CPU FIFO-not-empty interrupt
+
+ "#mbox-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - "#mbox-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ vpu_ipc_mailbox@203300f0 {
+ compatible = "intel,vpu-ipc-mailbox";
+ #mbox-cells = <1>;
+ reg = <0x203300f0 0x310>,
+ <0x208200f0 0x310>;
+ reg-names = "cpu_fifo", "vpu_fifo";
+ interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 667d03852191..68e6af3e5650 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9179,6 +9179,12 @@ L: [email protected]
S: Maintained
F: drivers/platform/x86/intel-vbtn.c

+INTEL VPU IPC MAILBOX
+M: Daniele Alessandrelli <[email protected]>
+M: Mark Gross <[email protected]>
+S: Supported
+F: Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
+
INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy)
M: Stanislaw Gruszka <[email protected]>
L: [email protected]
--
2.17.1


2021-03-05 20:52:59

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v6 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings

On Fri, 12 Feb 2021 14:22:32 -0800, [email protected] wrote:
> From: Daniele Alessandrelli <[email protected]>
>
> Add bindings for the Intel VPU IPC mailbox driver.
>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> Signed-off-by: Daniele Alessandrelli <[email protected]>
> Signed-off-by: Mark Gross <[email protected]>
> ---
> .../mailbox/intel,vpu-ipc-mailbox.yaml | 69 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
>

Reviewed-by: Rob Herring <[email protected]>