2021-02-15 10:40:35

by Alexandru Ardelean

Subject: [PATCH v6 01/24] iio: adc: ti_am335x_adc: remove omitted iio_kfifo_free()

When the conversion was done to use devm_iio_kfifo_allocate(), a call to
iio_kfifo_free() was omitted (to be removed).
This change removes it.

Fixes: 3c5308058899 ("iio: adc: ti_am335x_adc: alloc kfifo & IRQ via devm_ functions")
Signed-off-by: Alexandru Ardelean <[email protected]>
---
drivers/iio/adc/ti_am335x_adc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index b11c8c47ba2a..e946903b0993 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -397,16 +397,12 @@ static int tiadc_iio_buffered_hardware_setup(struct device *dev,
ret = devm_request_threaded_irq(dev, irq, pollfunc_th, pollfunc_bh,
flags, indio_dev->name, indio_dev);
if (ret)
- goto error_kfifo_free;
+ return ret;

indio_dev->setup_ops = setup_ops;
indio_dev->modes |= INDIO_BUFFER_SOFTWARE;

return 0;
-
-error_kfifo_free:
- iio_kfifo_free(indio_dev->buffer);
- return ret;
}

static const char * const chan_name_ain[] = {
--
2.17.1

2021-02-15 11:23:24

by Jonathan Cameron

Subject: Re: [PATCH v6 01/24] iio: adc: ti_am335x_adc: remove omitted iio_kfifo_free()

On Mon, 15 Feb 2021 12:40:20 +0200
Alexandru Ardelean <[email protected]> wrote:

> When the conversion was done to use devm_iio_kfifo_allocate(), a call to
> iio_kfifo_free() was omitted (to be removed).
> This change removes it.
>
> Fixes: 3c5308058899 ("iio: adc: ti_am335x_adc: alloc kfifo & IRQ via devm_ functions")
> Signed-off-by: Alexandru Ardelean <[email protected]>

Hi Alex,

I'm going to work my way through the series - may get to the end, but if
not hopefully we can at least reduce the number of outstanding patches.

To enable that I've rebased my togreg branch of staging/staging-next
(I hadn't pushed it out as a non rebasing tree so this shouldn't impact anyone too
badly).

Therefore, dropping this patch as it's already there.

Jonathan


> ---
> drivers/iio/adc/ti_am335x_adc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index b11c8c47ba2a..e946903b0993 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -397,16 +397,12 @@ static int tiadc_iio_buffered_hardware_setup(struct device *dev,
> ret = devm_request_threaded_irq(dev, irq, pollfunc_th, pollfunc_bh,
> flags, indio_dev->name, indio_dev);
> if (ret)
> - goto error_kfifo_free;
> + return ret;
>
> indio_dev->setup_ops = setup_ops;
> indio_dev->modes |= INDIO_BUFFER_SOFTWARE;
>
> return 0;
> -
> -error_kfifo_free:
> - iio_kfifo_free(indio_dev->buffer);
> - return ret;
> }
>
> static const char * const chan_name_ain[] = {