2021-02-16 16:46:25

by angkery

Subject: [PATCH] phy: rockchip-typec: add missing of_node_put

From: Junlin Yang <[email protected]>

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-typec.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 70a3125..d2bbdc9 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -1180,6 +1180,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
dev_err(dev, "failed to create phy: %pOFn\n",
child_np);
pm_runtime_disable(dev);
+ of_node_put(child_np);
return PTR_ERR(phy);
}

--
1.9.1

2021-03-15 10:08:20

by Vinod Koul

Subject: Re: [PATCH] phy: rockchip-typec: add missing of_node_put

On 16-02-21, 16:48, angkery wrote:
> From: Junlin Yang <[email protected]>
>
> Fix OF node leaks by calling of_node_put in
> for_each_available_child_of_node when the cycle returns.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied, thanks

--
~Vinod