2021-02-17 14:28:05

by Vasanth

Subject: [PATCH] Staging: hv: channel.c: fixed a tab spaces before space hv: connection.c fixed a "=" sign without space in code

Signed-off-by: Vasanth Mathivanan <[email protected]>
---
drivers/hv/channel.c | 2 +-
drivers/hv/connection.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 6fb0c76bfbf8..587234065e37 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -385,7 +385,7 @@ static int create_gpadl_header(enum hv_gpadl_type type, void *kbuffer,
* @kbuffer: from kmalloc or vmalloc
* @size: page-size multiple
* @send_offset: the offset (in bytes) where the send ring buffer starts,
- * should be 0 for BUFFER type gpadl
+ * should be 0 for BUFFER type gpadl
* @gpadl_handle: some funky thing
*/
static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 11170d9a2e1a..3760cbb6ffaf 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -28,7 +28,7 @@ struct vmbus_connection vmbus_connection = {
.conn_state = DISCONNECTED,
.next_gpadl_handle = ATOMIC_INIT(0xE1E10),

- .ready_for_suspend_event= COMPLETION_INITIALIZER(
+ .ready_for_suspend_event = COMPLETION_INITIALIZER(
vmbus_connection.ready_for_suspend_event),
.ready_for_resume_event = COMPLETION_INITIALIZER(
vmbus_connection.ready_for_resume_event),
--
2.25.1

2021-02-17 23:54:51

by Michael Kelley (LINUX)

Subject: RE: [PATCH] Staging: hv: channel.c: fixed a tab spaces before space hv: connection.c fixed a "=" sign without space in code

From: Vasanth <[email protected]> Sent: Wednesday, February 17, 2021 6:22 AM
>
> Signed-off-by: Vasanth Mathivanan <[email protected]>
> ---
> drivers/hv/channel.c | 2 +-
> drivers/hv/connection.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 6fb0c76bfbf8..587234065e37 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -385,7 +385,7 @@ static int create_gpadl_header(enum hv_gpadl_type type, void
> *kbuffer,
> * @kbuffer: from kmalloc or vmalloc
> * @size: page-size multiple
> * @send_offset: the offset (in bytes) where the send ring buffer starts,
> - * should be 0 for BUFFER type gpadl
> + * should be 0 for BUFFER type gpadl
> * @gpadl_handle: some funky thing
> */
> static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
> index 11170d9a2e1a..3760cbb6ffaf 100644
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -28,7 +28,7 @@ struct vmbus_connection vmbus_connection = {
> .conn_state = DISCONNECTED,
> .next_gpadl_handle = ATOMIC_INIT(0xE1E10),
>
> - .ready_for_suspend_event= COMPLETION_INITIALIZER(
> + .ready_for_suspend_event = COMPLETION_INITIALIZER(
> vmbus_connection.ready_for_suspend_event),
> .ready_for_resume_event = COMPLETION_INITIALIZER(
> vmbus_connection.ready_for_resume_event),
> --
> 2.25.1

Vasanth -- your changes to fix the spacing look OK to me. However,
the Subject of the patch email is a bit unexpected, as the code
under drivers/hv is not a "Staging" driver. "Staging" drivers are
drivers under the pathname drivers/staging that have not been
fully accepted into the Linux kernel.

Changes to the code in the "hv" directory usually have a "Subject" line
that is prefixed with "Drivers: hv:" or "Drivers: hv: vmbus: ". For this
code, you can see the history of changes and the Subject lines at this URL:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/hv

Also, your submission does not have a commit message. While the
Subject captures the details of your change, the expectation is that
patches should also have a commit message, though in this case they
might be very similar. I would suggest shortening the Subject, and
then providing just a little bit more detail in the commit message.

Michael