2021-02-17 16:14:32

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH net-next v4 2/8] switchdev: mrp: Extend ring_role_mrp and in_role_mrp

On Wed, Feb 17, 2021 at 04:58:45PM +0100, Horatiu Vultur wrote:
> > If a driver implements full MRP offload for a ring/interconnect
> > manager/automanager, should it return -EOPNOTSUPP when sw_backup=false?
>
> In that case it should return 0.
> So if the driver can:
> - fully support MRP, when sw_backup = false, return 0. Then end of story.
> - partially support MRP, when sw_backup = false, return -EOPNOTSUPP,
> when sw_backup = true, return 0.
> - no support at all, return -EOPNOTSUPP.

Damn, I asked the wrong question.
I meant to ask about what it should return when sw_backup=true.
But you answered anyway that if it returns 0 when sw_backup=false, it
can simply not deal with the case where sw_backup=true, because that is
never supposed to happen.