2021-02-18 21:02:38

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning in Linus' tree

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.

Introduced by commit

c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")

Or maybe an ealier one.

This has been around for some time.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-02-18 22:50:47

by Ernst, Justin

[permalink] [raw]
Subject: RE: linux-next: build warning in Linus' tree

Hi,
We made a special effort to squash the unexpected indentation warnings in c159376490ee (https://lore.kernel.org/lkml/[email protected]/), so I was surprised to see this again.
Commit:

c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")

is the culprit here. I suspect it was written and submitted before we made the effort to fix the Unexpected indentation in c159376490ee, so it misplaced the first line of a codeblock, the original problem that was reported and fixed.

The fix:

diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
index 637c668cbe45..12ed843e1d3e 100644
--- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
+++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
@@ -39,8 +39,8 @@ Description:

The uv_type entry contains the hub revision number.
This value can be used to identify the UV system version::
- "0.*" = Hubless UV ('*' is subtype)

+ "0.*" = Hubless UV ('*' is subtype)
"3.0" = UV2
"5.0" = UV3
"7.0" = UV4

Thanks,
Justin

> Hi all,
>
> Building Linus' tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
>
> Introduced by commit
>
> c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
>
> Or maybe an ealier one.
>
> This has been around for some time.
>
> --
> Cheers,
> Stephen Rothwell

2021-02-24 00:28:19

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning in Linus' tree

Hi all,

On Thu, 18 Feb 2021 22:47:57 +0000 "Ernst, Justin" <[email protected]> wrote:
>
> Hi,
> We made a special effort to squash the unexpected indentation warnings in c159376490ee (https://lore.kernel.org/lkml/[email protected]/), so I was surprised to see this again.
> Commit:
>
> c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
>
> is the culprit here. I suspect it was written and submitted before we made the effort to fix the Unexpected indentation in c159376490ee, so it misplaced the first line of a codeblock, the original problem that was reported and fixed.
>
> The fix:
>
> diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> index 637c668cbe45..12ed843e1d3e 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> +++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> @@ -39,8 +39,8 @@ Description:
>
> The uv_type entry contains the hub revision number.
> This value can be used to identify the UV system version::
> - "0.*" = Hubless UV ('*' is subtype)
>
> + "0.*" = Hubless UV ('*' is subtype)
> "3.0" = UV2
> "5.0" = UV3
> "7.0" = UV4
>
> Thanks,
> Justin
>
> > Building Linus' tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> >
> > Introduced by commit
> >
> > c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
> >
> > Or maybe an ealier one.
> >
> > This has been around for some time.

I am still seeing this warning.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-02-24 00:33:33

by Ernst, Justin

[permalink] [raw]
Subject: RE: linux-next: build warning in Linus' tree

> Hi all,
>
> On Thu, 18 Feb 2021 22:47:57 +0000 "Ernst, Justin" <[email protected]> wrote:
> >
> > Hi,
> > We made a special effort to squash the unexpected indentation warnings in c159376490ee
> (https://lore.kernel.org/lkml/[email protected]/), so I was surprised to
> see this again.
> > Commit:
> >
> > c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
> >
> > is the culprit here. I suspect it was written and submitted before we made the effort to fix the
> Unexpected indentation in c159376490ee, so it misplaced the first line of a codeblock, the original
> problem that was reported and fixed.
> >
> > The fix:
> >
> > diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-
> firmware-sgi_uv
> > index 637c668cbe45..12ed843e1d3e 100644
> > --- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> > +++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> > @@ -39,8 +39,8 @@ Description:
> >
> > The uv_type entry contains the hub revision number.
> > This value can be used to identify the UV system version::
> > - "0.*" = Hubless UV ('*' is subtype)
> >
> > + "0.*" = Hubless UV ('*' is subtype)
> > "3.0" = UV2
> > "5.0" = UV3
> > "7.0" = UV4
> >
> > Thanks,
> > Justin
> >
> > > Building Linus' tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > >
> > > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> > >
> > > Introduced by commit
> > >
> > > c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
> > >
> > > Or maybe an ealier one.
> > >
> > > This has been around for some time.
>
> I am still seeing this warning.

I submitted a patch here: https://lore.kernel.org/lkml/[email protected]/

Thanks,
Justin Ernst

>
> --
> Cheers,
> Stephen Rothwell