2021-02-19 18:31:30

by Ernst, Justin

[permalink] [raw]
Subject: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

commit c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")

misplaced the first line of a codeblock section, causing the reported
warning message:
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.

Move the misplaced line below the required blank line to remove the
warning message.

Reported-by: Stephen Rothwell <[email protected]>
Fixes: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
Acked-by: Mike Travis <[email protected]>
Signed-off-by: Justin Ernst <[email protected]>
---
Documentation/ABI/testing/sysfs-firmware-sgi_uv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
index 637c668cbe45..12ed843e1d3e 100644
--- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
+++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
@@ -39,8 +39,8 @@ Description:

The uv_type entry contains the hub revision number.
This value can be used to identify the UV system version::
- "0.*" = Hubless UV ('*' is subtype)

+ "0.*" = Hubless UV ('*' is subtype)
"3.0" = UV2
"5.0" = UV3
"7.0" = UV4
--
2.26.2


Subject: [tip: x86/platform] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

The following commit has been merged into the x86/platform branch of tip:

Commit-ID: 2430915f8291212f2bd2155176b817c34a18a2b1
Gitweb: https://git.kernel.org/tip/2430915f8291212f2bd2155176b817c34a18a2b1
Author: Justin Ernst <[email protected]>
AuthorDate: Fri, 19 Feb 2021 12:28:52 -06:00
Committer: Borislav Petkov <[email protected]>
CommitterDate: Mon, 01 Mar 2021 11:14:25 +01:00

x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

Commit

c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")

misplaced the first line of a codeblock section, causing the reported
warning message:

Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.

Move the misplaced line below the required blank line to remove the
warning message.

Fixes: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Justin Ernst <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Acked-by: Mike Travis <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
Documentation/ABI/testing/sysfs-firmware-sgi_uv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
index 637c668..12ed843 100644
--- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
+++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
@@ -39,8 +39,8 @@ Description:

The uv_type entry contains the hub revision number.
This value can be used to identify the UV system version::
- "0.*" = Hubless UV ('*' is subtype)

+ "0.*" = Hubless UV ('*' is subtype)
"3.0" = UV2
"5.0" = UV3
"7.0" = UV4

2021-03-04 16:41:15

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

On Thu, Mar 04, 2021 at 12:55:49PM +0100, Hans de Goede wrote:
> Since this documentation documents the interface exposed by:
> drivers/platform/x86/uv_sysfs.c
>
> I've applied this patch to the pdx86 tree now:

I've queued it already:

https://git.kernel.org/tip/2430915f8291212f2bd2155176b817c34a18a2b1

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

2021-03-04 16:41:45

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

Hi,

On 2/19/21 6:28 PM, Justin Ernst wrote:
> commit c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
>
> misplaced the first line of a codeblock section, causing the reported
> warning message:
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
>
> Move the misplaced line below the required blank line to remove the
> warning message.
>
> Reported-by: Stephen Rothwell <[email protected]>
> Fixes: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
> Acked-by: Mike Travis <[email protected]>
> Signed-off-by: Justin Ernst <[email protected]>

Thank you for the patch.

Since this documentation documents the interface exposed by:
drivers/platform/x86/uv_sysfs.c

I've applied this patch to the pdx86 tree now:

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> Documentation/ABI/testing/sysfs-firmware-sgi_uv | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> index 637c668cbe45..12ed843e1d3e 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> +++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> @@ -39,8 +39,8 @@ Description:
>
> The uv_type entry contains the hub revision number.
> This value can be used to identify the UV system version::
> - "0.*" = Hubless UV ('*' is subtype)
>
> + "0.*" = Hubless UV ('*' is subtype)
> "3.0" = UV2
> "5.0" = UV3
> "7.0" = UV4
>

2021-03-04 16:43:47

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

Hi,

On 3/4/21 12:59 PM, Borislav Petkov wrote:
> On Thu, Mar 04, 2021 at 12:55:49PM +0100, Hans de Goede wrote:
>> Since this documentation documents the interface exposed by:
>> drivers/platform/x86/uv_sysfs.c
>>
>> I've applied this patch to the pdx86 tree now:
>
> I've queued it already:
>
> https://git.kernel.org/tip/2430915f8291212f2bd2155176b817c34a18a2b1

Thanks for letting me know, I'll drop it then.

Regards,

Hans

Subject: [tip: x86/platform] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

The following commit has been merged into the x86/platform branch of tip:

Commit-ID: e93d757c3f33c8a09f4aae579da4dc4500707471
Gitweb: https://git.kernel.org/tip/e93d757c3f33c8a09f4aae579da4dc4500707471
Author: Justin Ernst <[email protected]>
AuthorDate: Fri, 19 Feb 2021 12:28:52 -06:00
Committer: Borislav Petkov <[email protected]>
CommitterDate: Sat, 06 Mar 2021 12:28:35 +01:00

x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

Commit

c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")

misplaced the first line of a codeblock section, causing the reported
warning message:

Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.

Move the misplaced line below the required blank line to remove the
warning message.

Fixes: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Justin Ernst <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Acked-by: Mike Travis <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
Documentation/ABI/testing/sysfs-firmware-sgi_uv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
index 637c668..12ed843 100644
--- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
+++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
@@ -39,8 +39,8 @@ Description:

The uv_type entry contains the hub revision number.
This value can be used to identify the UV system version::
- "0.*" = Hubless UV ('*' is subtype)

+ "0.*" = Hubless UV ('*' is subtype)
"3.0" = UV2
"5.0" = UV3
"7.0" = UV4