2021-02-19 20:29:23

by Amrit Khera

Subject: [PATCH] staging: wimax: Fix block comment style issue in stack.c

This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".

Signed-off-by: Amrit Khera <[email protected]>
---
drivers/staging/wimax/stack.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..781426000015 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
* close to where the data is generated.
*/
/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
+ * static const struct nla_policy
+ * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
+ * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
+ * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
+ * };
+ */


/*
--
2.20.1

2021-02-21 13:07:36

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wimax: Fix block comment style issue in stack.c

On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
>
> Signed-off-by: Amrit Khera <[email protected]>
> ---
> drivers/staging/wimax/stack.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..781426000015 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
> * close to where the data is generated.
> */
> /*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> - [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> - [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
> -*/
> + * static const struct nla_policy
> + * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> + * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> + * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> + * };
> + */

Why not just remove this variable entirely? It's obviously not needed,
so just delete the thing.

thanks,

greg k-h