by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH v8 3/9] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

Hi Mirela,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next linus/master v5.11 next-20210222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mirela-Rabulea/Add-V4L2-driver-for-i-MX8-JPEG-Encoder-Decoder/20210223-031832
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-s001-20210222 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-229-g60c1f270-dirty
# https://github.com/0day-ci/linux/commit/6e821067180472a0ae64a91440bd234c86040310
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mirela-Rabulea/Add-V4L2-driver-for-i-MX8-JPEG-Encoder-Decoder/20210223-031832
git checkout 6e821067180472a0ae64a91440bd234c86040310
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

In file included from include/linux/printk.h:409,
from include/linux/kernel.h:16,
from drivers/media/platform/imx-jpeg/mxc-jpeg.c:43:
drivers/media/platform/imx-jpeg/mxc-jpeg.c: In function 'mxc_jpeg_config_enc_desc':
>> drivers/media/platform/imx-jpeg/mxc-jpeg.c:891:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
891 | dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/media/platform/imx-jpeg/mxc-jpeg.c:891:2: note: in expansion of macro 'dev_dbg'
891 | dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
| ^~~~~~~
drivers/media/platform/imx-jpeg/mxc-jpeg.c:891:38: note: format string is defined here
891 | dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
| ~~~^
| |
| long long unsigned int
| %x
In file included from include/linux/printk.h:409,
from include/linux/kernel.h:16,
from drivers/media/platform/imx-jpeg/mxc-jpeg.c:43:
drivers/media/platform/imx-jpeg/mxc-jpeg.c:893:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
893 | dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/media/platform/imx-jpeg/mxc-jpeg.c:893:2: note: in expansion of macro 'dev_dbg'
893 | dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
| ^~~~~~~
drivers/media/platform/imx-jpeg/mxc-jpeg.c:893:38: note: format string is defined here
893 | dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
| ~~~^
| |
| long long unsigned int
| %x
drivers/media/platform/imx-jpeg/mxc-jpeg.c: In function 'mxc_jpeg_probe':
>> drivers/media/platform/imx-jpeg/mxc-jpeg.c:2086:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
2086 | mode = (int)(u64)of_id->data;
| ^

vim +891 drivers/media/platform/imx-jpeg/mxc-jpeg.c

840
841 static void mxc_jpeg_config_enc_desc(struct vb2_buffer *out_buf,
842 struct mxc_jpeg_ctx *ctx,
843 struct vb2_buffer *src_buf,
844 struct vb2_buffer *dst_buf)
845 {
846 struct mxc_jpeg_dev *jpeg = ctx->mxc_jpeg;
847 void __iomem *reg = jpeg->base_reg;
848 unsigned int slot = ctx->slot;
849 struct mxc_jpeg_desc *desc = jpeg->slot_data[slot].desc;
850 struct mxc_jpeg_desc *cfg_desc = jpeg->slot_data[slot].cfg_desc;
851 dma_addr_t desc_handle = jpeg->slot_data[slot].desc_handle;
852 dma_addr_t cfg_desc_handle = jpeg->slot_data[slot].cfg_desc_handle;
853 void *cfg_stream_vaddr = jpeg->slot_data[slot].cfg_stream_vaddr;
854 struct mxc_jpeg_q_data *q_data;
855 enum mxc_jpeg_image_format img_fmt;
856 int w, h;
857
858 q_data = mxc_jpeg_get_q_data(ctx, src_buf->vb2_queue->type);
859
860 jpeg->slot_data[slot].cfg_stream_size =
861 mxc_jpeg_setup_cfg_stream(cfg_stream_vaddr,
862 q_data->fmt->fourcc,
863 q_data->w_adjusted,
864 q_data->h_adjusted);
865
866 /* chain the config descriptor with the encoding descriptor */
867 cfg_desc->next_descpt_ptr = desc_handle | MXC_NXT_DESCPT_EN;
868
869 cfg_desc->buf_base0 = jpeg->slot_data[slot].cfg_stream_handle;
870 cfg_desc->buf_base1 = 0;
871 cfg_desc->line_pitch = 0;
872 cfg_desc->stm_bufbase = 0; /* no output expected */
873 cfg_desc->stm_bufsize = 0x0;
874 cfg_desc->imgsize = 0;
875 cfg_desc->stm_ctrl = STM_CTRL_CONFIG_MOD(1);
876
877 desc->next_descpt_ptr = 0; /* end of chain */
878
879 /* use adjusted resolution for CAST IP job */
880 w = q_data->w_adjusted;
881 h = q_data->h_adjusted;
882 mxc_jpeg_set_res(desc, w, h);
883 mxc_jpeg_set_line_pitch(desc, w * (q_data->fmt->depth / 8));
884 mxc_jpeg_set_bufsize(desc, desc->line_pitch * h);
885 img_fmt = mxc_jpeg_fourcc_to_imgfmt(q_data->fmt->fourcc);
886 if (img_fmt == MXC_JPEG_INVALID)
887 dev_err(jpeg->dev, "No valid image format detected\n");
888 desc->stm_ctrl = STM_CTRL_CONFIG_MOD(0) |
889 STM_CTRL_IMAGE_FORMAT(img_fmt);
890 mxc_jpeg_addrs(desc, src_buf, dst_buf, 0);
> 891 dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
892 print_descriptor_info(jpeg->dev, cfg_desc);
893 dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
894 print_descriptor_info(jpeg->dev, desc);
895 print_wrapper_info(jpeg->dev, reg);
896 print_cast_status(jpeg->dev, reg, MXC_JPEG_ENCODE);
897
898 /* validate the configuration descriptor */
899 mxc_jpeg_set_desc(cfg_desc_handle, reg, slot);
900 }
901

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachments:

(No filename) (8.12 kB)
.config.gz (33.46 kB)
Download all attachments

2021-02-22 22:42:40

by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH v8 9/9] media: imx-jpeg: Use v4l2 jpeg helpers in mxc-jpeg

Hi Mirela,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on shawnguo/for-next robh/for-next linus/master v5.11 next-20210222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mirela-Rabulea/Add-V4L2-driver-for-i-MX8-JPEG-Encoder-Decoder/20210223-031832
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-m001-20210222 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

smatch warnings:
drivers/media/platform/imx-jpeg/mxc-jpeg.c:1220 mxc_jpeg_parse() warn: inconsistent indenting

vim +1220 drivers/media/platform/imx-jpeg/mxc-jpeg.c

1190
1191 static int mxc_jpeg_parse(struct mxc_jpeg_ctx *ctx,
1192 u8 *src_addr, u32 size, bool *dht_needed)
1193 {
1194 struct device *dev = ctx->mxc_jpeg->dev;
1195 struct mxc_jpeg_q_data *q_data_out, *q_data_cap;
1196 enum v4l2_buf_type cap_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
1197 bool src_chg = false;
1198 u32 fourcc;
1199 struct v4l2_jpeg_header header;
1200 struct mxc_jpeg_sof *psof = NULL;
1201 struct mxc_jpeg_sos *psos = NULL;
1202 int ret;
1203
1204 memset(&header, 0, sizeof(header));
1205 ret = v4l2_jpeg_parse_header((void *)src_addr, size, &header);
1206 if (ret < 0) {
1207 dev_err(dev, "Error parsing JPEG stream markers\n");
1208 return ret;
1209 }
1210
1211 /* if DHT marker present, no need to inject default one */
1212 *dht_needed = (header.num_dht == 0);
1213
1214 q_data_out = mxc_jpeg_get_q_data(ctx,
1215 V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
1216 if (q_data_out->w == 0 && q_data_out->h == 0) {
1217 dev_warn(dev, "Invalid user resolution 0x0");
1218 dev_warn(dev, "Keeping resolution from JPEG: %dx%d",
1219 header.frame.width, header.frame.height);
> 1220 q_data_out->w = header.frame.width;
1221 q_data_out->h = header.frame.height;
1222 } else if (header.frame.width != q_data_out->w ||
1223 header.frame.height != q_data_out->h) {
1224 dev_err(dev,
1225 "Resolution mismatch: %dx%d (JPEG) versus %dx%d(user)",
1226 header.frame.width, header.frame.height,
1227 q_data_out->w, q_data_out->h);
1228 return -EINVAL;
1229 }
1230 if (header.frame.width % 8 != 0 || header.frame.height % 8 != 0) {
1231 dev_err(dev, "JPEG width or height not multiple of 8: %dx%d\n",
1232 header.frame.width, header.frame.height);
1233 return -EINVAL;
1234 }
1235 if (header.frame.width > MXC_JPEG_MAX_WIDTH ||
1236 header.frame.height > MXC_JPEG_MAX_HEIGHT) {
1237 dev_err(dev, "JPEG width or height should be <= 8192: %dx%d\n",
1238 header.frame.width, header.frame.height);
1239 return -EINVAL;
1240 }
1241 if (header.frame.width < MXC_JPEG_MIN_WIDTH ||
1242 header.frame.height < MXC_JPEG_MIN_HEIGHT) {
1243 dev_err(dev, "JPEG width or height should be > 64: %dx%d\n",
1244 header.frame.width, header.frame.height);
1245 return -EINVAL;
1246 }
1247 if (header.frame.num_components > V4L2_JPEG_MAX_COMPONENTS) {
1248 dev_err(dev, "JPEG number of components should be <=%d",
1249 V4L2_JPEG_MAX_COMPONENTS);
1250 return -EINVAL;
1251 }
1252 /* check and, if necessary, patch component IDs*/
1253 psof = (struct mxc_jpeg_sof *)header.sof.start;
1254 psos = (struct mxc_jpeg_sos *)header.sos.start;
1255 if (!mxc_jpeg_valid_comp_id(dev, psof, psos))
1256 dev_warn(dev, "JPEG component ids should be 0-3 or 1-4");
1257
1258 fourcc = mxc_jpeg_get_image_format(dev, header);
1259 if (fourcc == 0)
1260 return -EINVAL;
1261
1262 /*
1263 * set-up the capture queue with the pixelformat and resolution
1264 * detected from the jpeg output stream
1265 */
1266 q_data_cap = mxc_jpeg_get_q_data(ctx, cap_type);
1267 if (q_data_cap->w != header.frame.width ||
1268 q_data_cap->h != header.frame.height)
1269 src_chg = true;
1270 q_data_cap->w = header.frame.width;
1271 q_data_cap->h = header.frame.height;
1272 q_data_cap->fmt = mxc_jpeg_find_format(ctx, fourcc);
1273 q_data_cap->w_adjusted = q_data_cap->w;
1274 q_data_cap->h_adjusted = q_data_cap->h;
1275 /*
1276 * align up the resolution for CAST IP,
1277 * but leave the buffer resolution unchanged
1278 */
1279 v4l_bound_align_image(&q_data_cap->w_adjusted,
1280 q_data_cap->w_adjusted, /* adjust up */
1281 MXC_JPEG_MAX_WIDTH,
1282 q_data_cap->fmt->h_align,
1283 &q_data_cap->h_adjusted,
1284 q_data_cap->h_adjusted, /* adjust up */
1285 MXC_JPEG_MAX_HEIGHT,
1286 q_data_cap->fmt->v_align,
1287 0);
1288 dev_dbg(dev, "Detected jpeg res=(%dx%d)->(%dx%d), pixfmt=%c%c%c%c\n",
1289 q_data_cap->w, q_data_cap->h,
1290 q_data_cap->w_adjusted, q_data_cap->h_adjusted,
1291 (fourcc & 0xff),
1292 (fourcc >> 8) & 0xff,
1293 (fourcc >> 16) & 0xff,
1294 (fourcc >> 24) & 0xff);
1295
1296 /* setup bytesperline/sizeimage for capture queue */
1297 mxc_jpeg_bytesperline(q_data_cap, header.frame.precision);
1298 mxc_jpeg_sizeimage(q_data_cap);
1299
1300 /*
1301 * if the CAPTURE format was updated with new values, regardless of
1302 * whether they match the values set by the client or not, signal
1303 * a source change event
1304 */
1305 if (src_chg)
1306 notify_src_chg(ctx);
1307
1308 return 0;
1309 }
1310

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachments:

(No filename) (5.93 kB)
.config.gz (34.19 kB)
Download all attachments

2021-03-04 13:21:12

by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH v8 3/9] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

Hi Mirela,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on shawnguo/for-next robh/for-next linus/master v5.12-rc1 next-20210303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mirela-Rabulea/Add-V4L2-driver-for-i-MX8-JPEG-Encoder-Decoder/20210223-031832
base: git://linuxtv.org/media_tree.git master
config: powerpc64-randconfig-r004-20210303 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a7cad6680b4087eff8994f1f99ac40c661a6621f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/6e821067180472a0ae64a91440bd234c86040310
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mirela-Rabulea/Add-V4L2-driver-for-i-MX8-JPEG-Encoder-Decoder/20210223-031832
git checkout 6e821067180472a0ae64a91440bd234c86040310
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:236:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:238:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:240:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:3:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:5:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/media/platform/imx-jpeg/mxc-jpeg.c:45:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:7:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/media/platform/imx-jpeg/mxc-jpeg.c:891:45: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
~~~~ ^~~~~~~~~~~~~~~
%x
include/linux/dev_printk.h:123:39: note: expanded from macro 'dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:19: note: expanded from macro 'dynamic_dev_dbg'
dev, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:147:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:129:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/media/platform/imx-jpeg/mxc-jpeg.c:893:45: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
~~~~ ^~~~~~~~~~~
%x
include/linux/dev_printk.h:123:39: note: expanded from macro 'dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:19: note: expanded from macro 'dynamic_dev_dbg'
dev, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:147:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:129:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
8 warnings generated.

vim +891 drivers/media/platform/imx-jpeg/mxc-jpeg.c

840
841 static void mxc_jpeg_config_enc_desc(struct vb2_buffer *out_buf,
842 struct mxc_jpeg_ctx *ctx,
843 struct vb2_buffer *src_buf,
844 struct vb2_buffer *dst_buf)
845 {
846 struct mxc_jpeg_dev *jpeg = ctx->mxc_jpeg;
847 void __iomem *reg = jpeg->base_reg;
848 unsigned int slot = ctx->slot;
849 struct mxc_jpeg_desc *desc = jpeg->slot_data[slot].desc;
850 struct mxc_jpeg_desc *cfg_desc = jpeg->slot_data[slot].cfg_desc;
851 dma_addr_t desc_handle = jpeg->slot_data[slot].desc_handle;
852 dma_addr_t cfg_desc_handle = jpeg->slot_data[slot].cfg_desc_handle;
853 void *cfg_stream_vaddr = jpeg->slot_data[slot].cfg_stream_vaddr;
854 struct mxc_jpeg_q_data *q_data;
855 enum mxc_jpeg_image_format img_fmt;
856 int w, h;
857
858 q_data = mxc_jpeg_get_q_data(ctx, src_buf->vb2_queue->type);
859
860 jpeg->slot_data[slot].cfg_stream_size =
861 mxc_jpeg_setup_cfg_stream(cfg_stream_vaddr,
862 q_data->fmt->fourcc,
863 q_data->w_adjusted,
864 q_data->h_adjusted);
865
866 /* chain the config descriptor with the encoding descriptor */
867 cfg_desc->next_descpt_ptr = desc_handle | MXC_NXT_DESCPT_EN;
868
869 cfg_desc->buf_base0 = jpeg->slot_data[slot].cfg_stream_handle;
870 cfg_desc->buf_base1 = 0;
871 cfg_desc->line_pitch = 0;
872 cfg_desc->stm_bufbase = 0; /* no output expected */
873 cfg_desc->stm_bufsize = 0x0;
874 cfg_desc->imgsize = 0;
875 cfg_desc->stm_ctrl = STM_CTRL_CONFIG_MOD(1);
876
877 desc->next_descpt_ptr = 0; /* end of chain */
878
879 /* use adjusted resolution for CAST IP job */
880 w = q_data->w_adjusted;
881 h = q_data->h_adjusted;
882 mxc_jpeg_set_res(desc, w, h);
883 mxc_jpeg_set_line_pitch(desc, w * (q_data->fmt->depth / 8));
884 mxc_jpeg_set_bufsize(desc, desc->line_pitch * h);
885 img_fmt = mxc_jpeg_fourcc_to_imgfmt(q_data->fmt->fourcc);
886 if (img_fmt == MXC_JPEG_INVALID)
887 dev_err(jpeg->dev, "No valid image format detected\n");
888 desc->stm_ctrl = STM_CTRL_CONFIG_MOD(0) |
889 STM_CTRL_IMAGE_FORMAT(img_fmt);
890 mxc_jpeg_addrs(desc, src_buf, dst_buf, 0);
> 891 dev_dbg(jpeg->dev, "cfg_desc - 0x%llx:\n", cfg_desc_handle);
892 print_descriptor_info(jpeg->dev, cfg_desc);
893 dev_dbg(jpeg->dev, "enc desc - 0x%llx:\n", desc_handle);
894 print_descriptor_info(jpeg->dev, desc);
895 print_wrapper_info(jpeg->dev, reg);
896 print_cast_status(jpeg->dev, reg, MXC_JPEG_ENCODE);
897
898 /* validate the configuration descriptor */
899 mxc_jpeg_set_desc(cfg_desc_handle, reg, slot);
900 }
901

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachments:

(No filename) (12.65 kB)
.config.gz (40.49 kB)
Download all attachments