2021-02-23 03:06:21

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH v2] netdevsim: fib: remove unneeded semicolon

Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
- Remove the braces.

drivers/net/netdevsim/fib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..3acfe27 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -559,9 +559,8 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
return fib6_rt;

err_fib6_rt_nh_del:
- for (i--; i >= 0; i--) {
+ for (i--; i >= 0; i--)
nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
- };
nsim_fib_rt_fini(&fib6_rt->common);
kfree(fib6_rt);
return ERR_PTR(err);
--
1.8.3.1


2021-02-23 11:11:37

by Ido Schimmel

[permalink] [raw]
Subject: Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon

On Tue, Feb 23, 2021 at 10:28:46AM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Ido Schimmel <[email protected]>

2021-02-23 16:39:13

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon

On Tue, 23 Feb 2021 10:28:46 +0800 Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

# Form letter - net-next is closed

We have already sent the networking pull request for 5.12
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 5.12-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.