2021-02-24 15:47:34

by Colin King

Subject: [PATCH][next] i3c: master: svc: remove redundant assignment to cmd->read_len

From: Colin Ian King <[email protected]>

The assignment of xfer_len to cmd->read_len appears to be redundant
as the next statement re-assigns the value 0 to it. Clean up the
code by removing the redundant first assignment.

Addresses-Coverity: ("Unused value")
Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/i3c/master/svc-i3c-master.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 8d990696676e..1f6ba4221817 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1124,7 +1124,6 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct svc_i3c_master *master,
cmd->in = NULL;
cmd->out = &ccc->id;
cmd->len = 1;
- cmd->read_len = xfer_len;
cmd->read_len = 0;
cmd->continued = true;

--
2.30.0

2021-03-04 06:33:22

by Miquel Raynal

Subject: Re: [PATCH][next] i3c: master: svc: remove redundant assignment to cmd->read_len

Colin King <[email protected]> wrote on Wed, 24 Feb 2021
15:13:49 +0000:

> From: Colin Ian King <[email protected]>
>
> The assignment of xfer_len to cmd->read_len appears to be redundant
> as the next statement re-assigns the value 0 to it. Clean up the
> code by removing the redundant first assignment.
>
> Addresses-Coverity: ("Unused value")
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/i3c/master/svc-i3c-master.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 8d990696676e..1f6ba4221817 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1124,7 +1124,6 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct svc_i3c_master *master,
> cmd->in = NULL;
> cmd->out = &ccc->id;
> cmd->len = 1;
> - cmd->read_len = xfer_len;
> cmd->read_len = 0;
> cmd->continued = true;
>

Reviewed-by: Miquel Raynal <[email protected]>

Thanks,
Miquèl

2021-03-04 18:56:26

by Alexandre Belloni

Subject: Re: [PATCH][next] i3c: master: svc: remove redundant assignment to cmd->read_len

On Wed, 24 Feb 2021 15:13:49 +0000, Colin King wrote:
> The assignment of xfer_len to cmd->read_len appears to be redundant
> as the next statement re-assigns the value 0 to it. Clean up the
> code by removing the redundant first assignment.

Applied, thanks!

[1/1] i3c: master: svc: remove redundant assignment to cmd->read_len
commit: 437f5e2af73081ec08ec5d73d82c650377a4bb17

Best regards,
--
Alexandre Belloni <[email protected]>