2021-02-28 01:12:30

by Darryl T. Agostinelli

Subject: [PATCH] staging: rtl8192u avoid flex array of flex array

Undo the flex array in struct ieee80211_info_element. It is used as the flex
array type in other structs (creating a flex array of flex arrays) making
sparse unhappy. This change maintains the intent of the code and satisfies
sparse.

Signed-off-by: Darryl T. Agostinelli <[email protected]>
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
index 39f4ddd86796..43bb7aeb35e3 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
@@ -951,7 +951,7 @@ struct rtl_80211_hdr_4addrqos {
struct ieee80211_info_element {
u8 id;
u8 len;
- u8 data[];
+ u8 data[0];
} __packed;

struct ieee80211_authentication {
--
2.29.2

2021-03-01 06:35:30

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8192u avoid flex array of flex array

On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote:
> Undo the flex array in struct ieee80211_info_element. It is used as the flex
> array type in other structs (creating a flex array of flex arrays) making
> sparse unhappy. This change maintains the intent of the code and satisfies
> sparse.
>
> Signed-off-by: Darryl T. Agostinelli <[email protected]>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 39f4ddd86796..43bb7aeb35e3 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -951,7 +951,7 @@ struct rtl_80211_hdr_4addrqos {
> struct ieee80211_info_element {
> u8 id;
> u8 len;
> - u8 data[];
> + u8 data[0];

Nah... Just ignore Sparse on this.

regards,
dan carpenter

2021-03-04 06:29:37

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8192u avoid flex array of flex array

On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote:
> Undo the flex array in struct ieee80211_info_element. It is used as the flex
> array type in other structs (creating a flex array of flex arrays) making
> sparse unhappy. This change maintains the intent of the code and satisfies
> sparse.

We have been trying to convert the kernel to use the [] style over time,
please don't move backwards on this. There are loads of commits by
Gustavo in the tree that show this work.

thanks,

greg k-h