Seems the first submission somehow didn't make it to LKML, here's a
resend.
The only usage of the structs is to pass their address to
sysfs_create_group() and sysfs_remove_group(), both which takes pointers
to const attribute_group structs. Make them const to allow the compiler
to put them in read-only memory.
Done with the help of coccinelle.
With these patches applied, all static attribute_group structs in
drivers/mfd are const.
Rikard Falkeborn (3):
mfd: gateworks-gsc: Constify static struct attribute_group
mfd: lm3533: Constify static struct attribute_group
mfd: pcf50633: Constify static struct attribute_group
drivers/mfd/gateworks-gsc.c | 2 +-
drivers/mfd/lm3533-core.c | 2 +-
drivers/mfd/pcf50633-core.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.30.1
The only usage of pcf_attr_group is to pass its address to
sysfs_create_group() and sysfs_remove_group(), both which takes pointers
to const attribute_group structs. Make it const to allow the compiler to
put it in read-only memory.
Done with the help of coccinelle.
Signed-off-by: Rikard Falkeborn <[email protected]>
---
drivers/mfd/pcf50633-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 148bcd6120f4..0768d684113a 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -131,7 +131,7 @@ static struct attribute *pcf_sysfs_entries[] = {
NULL,
};
-static struct attribute_group pcf_attr_group = {
+static const struct attribute_group pcf_attr_group = {
.name = NULL, /* put in device directory */
.attrs = pcf_sysfs_entries,
};
--
2.30.1
The only usage of lm3533_attribute_group is to pass its address to
sysfs_create_group() and sysfs_remove_group(), both which takes pointers
to const attribute_group structs. Make it const to allow the compiler to
put it in read-only memory.
Done with the help of coccinelle.
Signed-off-by: Rikard Falkeborn <[email protected]>
---
drivers/mfd/lm3533-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 22fdffd564f7..523dcf05db78 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -373,7 +373,7 @@ static umode_t lm3533_attr_is_visible(struct kobject *kobj,
return mode;
};
-static struct attribute_group lm3533_attribute_group = {
+static const struct attribute_group lm3533_attribute_group = {
.is_visible = lm3533_attr_is_visible,
.attrs = lm3533_attributes
};
--
2.30.1