2021-03-04 08:34:06

by Qing Zhang

[permalink] [raw]
Subject: [PATCH v2 6/7] dt-bindings: interrupt-controller: Add Loongson-2K1000 LIOINTC

Add liointc-2.0 properties support, so update the maxItems and description.

Signed-off-by: Jiaxun Yang <[email protected]>
Signed-off-by: Qing Zhang <[email protected]>
---

v2:
- Add new patch

.../bindings/interrupt-controller/loongson,liointc.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
index f38e0113f360..96162b9d227c 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
@@ -10,9 +10,9 @@ maintainers:
- Jiaxun Yang <[email protected]>

description: |
- This interrupt controller is found in the Loongson-3 family of chips as the primary
- package interrupt controller which can route local I/O interrupt to interrupt lines
- of cores.
+ This interrupt controller is found in the Loongson-3 family of chips and
+ Loongson-2K1000 chip, as the primary package interrupt controller which
+ can route local I/O interrupt to interrupt lines of cores.

allOf:
- $ref: /schemas/interrupt-controller.yaml#
@@ -22,9 +22,10 @@ properties:
oneOf:
- const: loongson,liointc-1.0
- const: loongson,liointc-1.0a
+ - const: loongson,liointc-2.0

reg:
- maxItems: 1
+ maxItems: 3

interrupt-controller: true

--
2.20.1


2021-03-05 00:57:27

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] dt-bindings: interrupt-controller: Add Loongson-2K1000 LIOINTC

On Wed, 03 Mar 2021 14:24:33 +0800, Qing Zhang wrote:
> Add liointc-2.0 properties support, so update the maxItems and description.
>
> Signed-off-by: Jiaxun Yang <[email protected]>
> Signed-off-by: Qing Zhang <[email protected]>
> ---
>
> v2:
> - Add new patch
>
> .../bindings/interrupt-controller/loongson,liointc.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.example.dt.yaml: interrupt-controller@3ff01400: reg: [[1072698368, 100]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml

See https://patchwork.ozlabs.org/patch/1446855

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.