These two lines of code don't meet the kernel coding style,
so remove the redundant space.
Signed-off-by: maqiang <[email protected]>
---
drivers/char/lp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 862c2fd933c7..0e22e3b0a04e 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
}
/* Determine if the peripheral supports ECP mode */
lp_claim_parport_or_block(&lp_table[minor]);
- if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
+ if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
!parport_negotiate(lp_table[minor].dev->port,
IEEE1284_MODE_ECP)) {
printk(KERN_INFO "lp%d: ECP mode\n", minor);
@@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
return -ENODEV;
if ((LP_F(minor) & LP_EXIST) == 0)
return -ENODEV;
- switch ( cmd ) {
+ switch (cmd) {
case LPTIME:
if (arg > UINT_MAX / HZ)
return -EINVAL;
--
2.20.1
On Wed, Mar 03, 2021 at 07:39:38PM +0800, maqiang wrote:
> These two lines of code don't meet the kernel coding style,
> so remove the redundant space.
>
> Signed-off-by: maqiang <[email protected]>
Please use your "full" name that you sign legal documents with.
thanks,
greg k-h
On Thu, Mar 04, 2021 at 03:21:47PM +0800, maqiang wrote:
> These two lines of code don't meet the kernel coding style,
> so remove the redundant space.
>
> Signed-off-by: Qiang Ma <[email protected]>
> Signed-off-by: maqiang <[email protected]>
Why do you have 2 signed-off-by lines with the same email address, but
different names?
If you want to start out in kernel development for coding style fixes, I
recommend doing so in drivers/staging/ as patches there for things like
this are more welcome than other parts of the kernel.
thanks,
greg k-h