2021-03-04 10:16:43

by Qiang Ma

Subject: [PATCH] powerpc: remove redundant space

These one line of code don't meet the kernel coding style,
so remove the redundant space.

Signed-off-by: maqiang <[email protected]>
---
arch/powerpc/kernel/syscalls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
index 078608ec2e92..9248288752d5 100644
--- a/arch/powerpc/kernel/syscalls.c
+++ b/arch/powerpc/kernel/syscalls.c
@@ -81,7 +81,7 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
int
ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp, struct __kernel_old_timeval __user *tvp)
{
- if ( (unsigned long)n >= 4096 )
+ if ((unsigned long)n >= 4096)
{
unsigned long __user *buffer = (unsigned long __user *)n;
if (!access_ok(buffer, 5*sizeof(unsigned long))
--
2.20.1

2021-03-04 13:07:26

by Christophe Leroy

Subject: Re: [PATCH] powerpc: remove redundant space

maqiang <[email protected]> a écrit :

> These one line of code don't meet the kernel coding style,
> so remove the redundant space.

There seems to be several other style issues in this function and in
the following one too. You should fix them all at once I think.


>
> Signed-off-by: maqiang <[email protected]>
> ---
> arch/powerpc/kernel/syscalls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
> index 078608ec2e92..9248288752d5 100644
> --- a/arch/powerpc/kernel/syscalls.c
> +++ b/arch/powerpc/kernel/syscalls.c
> @@ -81,7 +81,7 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
> int
> ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set
> __user *exp, struct __kernel_old_timeval __user *tvp)
> {
> - if ( (unsigned long)n >= 4096 )
> + if ((unsigned long)n >= 4096)
> {
> unsigned long __user *buffer = (unsigned long __user *)n;
> if (!access_ok(buffer, 5*sizeof(unsigned long))
> --
> 2.20.1