2021-03-05 14:30:49

by Denis Efremov (Oracle)

Subject: [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

"len > sp->mtu" checked twice in a row in sp_encaps().
Remove the second check.

Signed-off-by: Denis Efremov <[email protected]>
---
drivers/net/hamradio/6pack.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 71d6629e65c9..9f5b5614a150 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -171,11 +171,6 @@ static void sp_encaps(struct sixpack *sp, unsigned char *icp, int len)
goto out_drop;
}

- if (len > sp->mtu) { /* sp->mtu = AX25_MTU = max. PACLEN = 256 */
- msg = "oversized transmit packet!";
- goto out_drop;
- }
-
if (p[0] > 5) {
msg = "invalid KISS command";
goto out_drop;
--
2.26.2

2021-03-05 21:15:04

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 5 Mar 2021 19:26:22 +0300 you wrote:
> "len > sp->mtu" checked twice in a row in sp_encaps().
> Remove the second check.
>
> Signed-off-by: Denis Efremov <[email protected]>
> ---
> drivers/net/hamradio/6pack.c | 5 -----
> 1 file changed, 5 deletions(-)

Here is the summary with links:
- net/hamradio/6pack: remove redundant check in sp_encaps()
https://git.kernel.org/netdev/net/c/85554bcd123e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html