2021-03-05 18:46:29

by Rafael J. Wysocki

Subject: [PATCH v1 3/4] IIO: acpi-als: Get rid of ACPICA message printing

From: Rafael J. Wysocki <[email protected]>

Use acpi_evaluation_failure_warn() introduced previously instead of
the ACPICA-specific ACPI_EXCEPTION() macro to log warning messages
regarding ACPI object evaluation failures and drop the
ACPI_MODULE_NAME() definition only used by the ACPICA message
printing macro.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/iio/light/acpi-als.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-pm/drivers/iio/light/acpi-als.c
===================================================================
--- linux-pm.orig/drivers/iio/light/acpi-als.c
+++ linux-pm/drivers/iio/light/acpi-als.c
@@ -26,8 +26,6 @@
#define ACPI_ALS_DEVICE_NAME "acpi-als"
#define ACPI_ALS_NOTIFY_ILLUMINANCE 0x80

-ACPI_MODULE_NAME("acpi-als");
-
/*
* So far, there's only one channel in here, but the specification for
* ACPI0008 says there can be more to what the block can report. Like
@@ -91,7 +89,7 @@ static int acpi_als_read_value(struct ac
&temp_val);

if (ACPI_FAILURE(status)) {
- ACPI_EXCEPTION((AE_INFO, status, "Error reading ALS %s", prop));
+ acpi_evaluation_failure_warn(als->device->handle, prop, status);
return -EIO;
}

2021-03-06 14:40:57

by Jonathan Cameron

Subject: Re: [PATCH v1 3/4] IIO: acpi-als: Get rid of ACPICA message printing

On Fri, 05 Mar 2021 19:42:29 +0100
"Rafael J. Wysocki" <[email protected]> wrote:

> From: Rafael J. Wysocki <[email protected]>
>
> Use acpi_evaluation_failure_warn() introduced previously instead of
> the ACPICA-specific ACPI_EXCEPTION() macro to log warning messages
> regarding ACPI object evaluation failures and drop the
> ACPI_MODULE_NAME() definition only used by the ACPICA message
> printing macro.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>

Acked-by: Jonathan Cameron <[email protected]>

> ---
> drivers/iio/light/acpi-als.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-pm/drivers/iio/light/acpi-als.c
> ===================================================================
> --- linux-pm.orig/drivers/iio/light/acpi-als.c
> +++ linux-pm/drivers/iio/light/acpi-als.c
> @@ -26,8 +26,6 @@
> #define ACPI_ALS_DEVICE_NAME "acpi-als"
> #define ACPI_ALS_NOTIFY_ILLUMINANCE 0x80
>
> -ACPI_MODULE_NAME("acpi-als");
> -
> /*
> * So far, there's only one channel in here, but the specification for
> * ACPI0008 says there can be more to what the block can report. Like
> @@ -91,7 +89,7 @@ static int acpi_als_read_value(struct ac
> &temp_val);
>
> if (ACPI_FAILURE(status)) {
> - ACPI_EXCEPTION((AE_INFO, status, "Error reading ALS %s", prop));
> + acpi_evaluation_failure_warn(als->device->handle, prop, status);
> return -EIO;
> }
>
>
>
>