2021-03-06 11:59:37

by Bhaskar Chowdhury

Subject: [PATCH] sound: soc: codecs: Fix a spello in the file wm8955.c

s/sortd/sorted/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
sound/soc/codecs/wm8955.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
index 513df47bd87d..538bb8b0db39 100644
--- a/sound/soc/codecs/wm8955.c
+++ b/sound/soc/codecs/wm8955.c
@@ -151,7 +151,7 @@ static int wm8955_pll_factors(struct device *dev,
/* The oscilator should run at should be 90-100MHz, and
* there's a divide by 4 plus an optional divide by 2 in the
* output path to generate the system clock. The clock table
- * is sortd so we should always generate a suitable target. */
+ * is sorted so we should always generate a suitable target. */
target = Fout * 4;
if (target < 90000000) {
pll->outdiv = 1;
--
2.26.2

2021-03-08 07:06:16

by Charles Keepax

Subject: Re: [PATCH] sound: soc: codecs: Fix a spello in the file wm8955.c

On Sat, Mar 06, 2021 at 05:21:51PM +0530, Bhaskar Chowdhury wrote:
>
> s/sortd/sorted/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> sound/soc/codecs/wm8955.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
> index 513df47bd87d..538bb8b0db39 100644
> --- a/sound/soc/codecs/wm8955.c
> +++ b/sound/soc/codecs/wm8955.c
> @@ -151,7 +151,7 @@ static int wm8955_pll_factors(struct device *dev,
> /* The oscilator should run at should be 90-100MHz, and
> * there's a divide by 4 plus an optional divide by 2 in the
> * output path to generate the system clock. The clock table
> - * is sortd so we should always generate a suitable target. */
> + * is sorted so we should always generate a suitable target. */
> target = Fout * 4;
> if (target < 90000000) {
> pll->outdiv = 1;
> --
> 2.26.2
>

Content of the patch looks good, the commit message might need a
little work. The subject line needs to be appropriate for the
subsystem. Would be better to start with "ASoC: wm8955: " and
typo is a more standard term than spello :-)

Thanks,
Charles

2021-03-08 08:44:49

by Randy Dunlap

Subject: Re: [PATCH] sound: soc: codecs: Fix a spello in the file wm8955.c

On 3/6/21 3:51 AM, Bhaskar Chowdhury wrote:
>
> s/sortd/sorted/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

> ---
> sound/soc/codecs/wm8955.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
> index 513df47bd87d..538bb8b0db39 100644
> --- a/sound/soc/codecs/wm8955.c
> +++ b/sound/soc/codecs/wm8955.c
> @@ -151,7 +151,7 @@ static int wm8955_pll_factors(struct device *dev,
> /* The oscilator should run at should be 90-100MHz, and
> * there's a divide by 4 plus an optional divide by 2 in the
> * output path to generate the system clock. The clock table
> - * is sortd so we should always generate a suitable target. */
> + * is sorted so we should always generate a suitable target. */
> target = Fout * 4;
> if (target < 90000000) {
> pll->outdiv = 1;
> --
> 2.26.2
>


--
~Randy