2021-03-08 14:30:58

by Rasmus Villemoes

Subject: [PATCH] ARM: decompressor: remove unused global variable output_data

output_data seems to have been write-only since the flush_window()
callback was removed in commit e7db7b4270ed ("arm: add support for
LZO-compressed kernels").

Signed-off-by: Rasmus Villemoes <[email protected]>
---
arch/arm/boot/compressed/misc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index e1e9a5dde853..fdef4d413d24 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -103,8 +103,6 @@ static void putstr(const char *ptr)
extern char input_data[];
extern char input_data_end[];

-unsigned char *output_data;
-
unsigned long free_mem_ptr;
unsigned long free_mem_end_ptr;

@@ -145,7 +143,6 @@ decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,
{
int ret;

- output_data = (unsigned char *)output_start;
free_mem_ptr = free_mem_ptr_p;
free_mem_end_ptr = free_mem_ptr_end_p;
__machine_arch_type = arch_id;
@@ -154,7 +151,7 @@ decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,

putstr("Uncompressing Linux...");
ret = do_decompress(input_data, input_data_end - input_data,
- output_data, error);
+ (u8 *)output_start, error);
if (ret)
error("decompressor returned an error");
else
--
2.29.2

2021-03-18 12:47:21

by Rasmus Villemoes

Subject: Re: [PATCH] ARM: decompressor: remove unused global variable output_data

On 08/03/2021 15.29, Rasmus Villemoes wrote:
> output_data seems to have been write-only since the flush_window()
> callback was removed in commit e7db7b4270ed ("arm: add support for
> LZO-compressed kernels").

Ping.