2021-03-08 15:20:19

by Sebastian Reichel

[permalink] [raw]
Subject: [PATCHv2 0/4] Bx50v3 DT improvements

Bx50v3 DT improvements

These are a bunch of small unrelated improvements for the GE Bx50v3
device tree (and BA16 system on module, which is currently only used
by Bx50v3).

Changes since PATCHv1 [1]:
* change patch prefix for BA16 patches
* remove extra newline from PATCH 1/4
* keep 'status' at the end of FEC in PATCH 2/4

[1] https://lore.kernel.org/lkml/[email protected]/

Thanks for reviewing/merging them,

-- Sebastian

Ian Ray (1):
ARM: dts: imx: bx50v3: Define GPIO line names

Sebastian Reichel (3):
ARM: dts: imx6q-ba16: add USB OTG VBUS enable GPIO
ARM: dts: imx6q-ba16: improve PHY information
ARM: dts: imx: bx50v3: i2c GPIOs are open drain

arch/arm/boot/dts/imx6q-b450v3.dts | 5 +++++
arch/arm/boot/dts/imx6q-b650v3.dts | 5 +++++
arch/arm/boot/dts/imx6q-b850v3.dts | 5 +++++
arch/arm/boot/dts/imx6q-ba16.dtsi | 21 +++++++++++++++++++++
arch/arm/boot/dts/imx6q-bx50v3.dtsi | 12 ++++++------
5 files changed, 42 insertions(+), 6 deletions(-)

--
2.30.1


2021-03-08 15:20:30

by Sebastian Reichel

[permalink] [raw]
Subject: [PATCHv2 4/4] ARM: dts: imx: bx50v3: Define GPIO line names

From: Ian Ray <[email protected]>

Define GPIO line names for b450v3, b650v3, and b850v3.

Signed-off-by: Ian Ray <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
---
arch/arm/boot/dts/imx6q-b450v3.dts | 5 +++++
arch/arm/boot/dts/imx6q-b650v3.dts | 5 +++++
arch/arm/boot/dts/imx6q-b850v3.dts | 5 +++++
3 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-b450v3.dts b/arch/arm/boot/dts/imx6q-b450v3.dts
index 604f2420370f..d994b32ad825 100644
--- a/arch/arm/boot/dts/imx6q-b450v3.dts
+++ b/arch/arm/boot/dts/imx6q-b450v3.dts
@@ -84,6 +84,11 @@ lvds0_out: endpoint {
};

&pca9539 {
+ gpio-line-names = "AMB_P_INT1#", "AMB_P_INT2#", "BT_EN", "WLAN_EN",
+ "", "SM_D_ACT", "DP1_RST#", "",
+ "WD15S_EN", "WD15S_DIS#", "", "",
+ "", "", "", "";
+
P04-hog {
gpio-hog;
gpios = <4 0>;
diff --git a/arch/arm/boot/dts/imx6q-b650v3.dts b/arch/arm/boot/dts/imx6q-b650v3.dts
index 56d2aeb1900c..fa1a1df37cde 100644
--- a/arch/arm/boot/dts/imx6q-b650v3.dts
+++ b/arch/arm/boot/dts/imx6q-b650v3.dts
@@ -84,6 +84,11 @@ lvds0_out: endpoint {
};

&pca9539 {
+ gpio-line-names = "AMB_P_INT1#", "AMB_P_INT2#", "BT_EN", "WLAN_EN",
+ "", "SM_D_ACT", "DP1_RST#", "",
+ "WD15S_EN", "WD15S_DIS#", "", "",
+ "", "", "", "";
+
P07-hog {
gpio-hog;
gpios = <7 0>;
diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts
index 3d6b757bf325..db8c332df6a1 100644
--- a/arch/arm/boot/dts/imx6q-b850v3.dts
+++ b/arch/arm/boot/dts/imx6q-b850v3.dts
@@ -199,6 +199,11 @@ stdp4028_out: endpoint {
};

&pca9539 {
+ gpio-line-names = "AMB_P_INT1#", "AMB_P_INT2#", "BT_EN", "WLAN_EN",
+ "REMOTE_ON_PML#", "SM_D_ACT", "DP1_RST#", "DP2_RST#",
+ "", "", "", "",
+ "", "", "", "";
+
P10-hog {
gpio-hog;
gpios = <8 0>;
--
2.30.1

2021-03-08 15:21:00

by Sebastian Reichel

[permalink] [raw]
Subject: [PATCHv2 3/4] ARM: dts: imx: bx50v3: i2c GPIOs are open drain

Explicitly mark I2C GPIOs as open drain to fix the following
kernel message being printed:

enforced open drain please flag it properly in DT/ACPI DSDT/board file

Signed-off-by: Sebastian Reichel <[email protected]>
---
arch/arm/boot/dts/imx6q-bx50v3.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/imx6q-bx50v3.dtsi b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
index 2a98cc657595..10922375c51e 100644
--- a/arch/arm/boot/dts/imx6q-bx50v3.dtsi
+++ b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
@@ -173,8 +173,8 @@ m25_eeprom: m25p80@0 {
&i2c1 {
pinctrl-names = "default", "gpio";
pinctrl-1 = <&pinctrl_i2c1_gpio>;
- sda-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>;
- scl-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
+ sda-gpios = <&gpio5 26 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ scl-gpios = <&gpio5 27 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;

pca9547: mux@70 {
compatible = "nxp,pca9547";
@@ -315,15 +315,15 @@ mux1_i2c8: i2c@7 {
&i2c2 {
pinctrl-names = "default", "gpio";
pinctrl-1 = <&pinctrl_i2c2_gpio>;
- sda-gpios = <&gpio4 13 GPIO_ACTIVE_HIGH>;
- scl-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>;
+ sda-gpios = <&gpio4 13 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ scl-gpios = <&gpio4 12 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
};

&i2c3 {
pinctrl-names = "default", "gpio";
pinctrl-1 = <&pinctrl_i2c3_gpio>;
- sda-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
- scl-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;
+ sda-gpios = <&gpio1 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ scl-gpios = <&gpio1 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
};

&iomuxc {
--
2.30.1

2021-03-15 06:12:09

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCHv2 0/4] Bx50v3 DT improvements

On Mon, Mar 08, 2021 at 04:18:25PM +0100, Sebastian Reichel wrote:
> Bx50v3 DT improvements
>
> These are a bunch of small unrelated improvements for the GE Bx50v3
> device tree (and BA16 system on module, which is currently only used
> by Bx50v3).
>
> Changes since PATCHv1 [1]:
> * change patch prefix for BA16 patches
> * remove extra newline from PATCH 1/4
> * keep 'status' at the end of FEC in PATCH 2/4
>
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> Thanks for reviewing/merging them,
>
> -- Sebastian
>
> Ian Ray (1):
> ARM: dts: imx: bx50v3: Define GPIO line names
>
> Sebastian Reichel (3):
> ARM: dts: imx6q-ba16: add USB OTG VBUS enable GPIO
> ARM: dts: imx6q-ba16: improve PHY information
> ARM: dts: imx: bx50v3: i2c GPIOs are open drain

Applied all, thanks.