2021-03-08 18:10:15

by Álvaro Fernández Rojas

Subject: [PATCH] net: dsa: b53: relax is63xx() condition

BCM63xx switches are present on bcm63xx and bmips devices.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
drivers/net/dsa/b53/b53_priv.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h
index 8419bb7f4505..82700a5714c1 100644
--- a/drivers/net/dsa/b53/b53_priv.h
+++ b/drivers/net/dsa/b53/b53_priv.h
@@ -186,11 +186,7 @@ static inline int is531x5(struct b53_device *dev)

static inline int is63xx(struct b53_device *dev)
{
-#ifdef CONFIG_BCM63XX
return dev->chip_id == BCM63XX_DEVICE_ID;
-#else
- return 0;
-#endif
}

static inline int is5301x(struct b53_device *dev)
--
2.20.1

2021-03-08 18:27:03

by Florian Fainelli

Subject: Re: [PATCH] net: dsa: b53: relax is63xx() condition

On 3/8/21 10:08 AM, Álvaro Fernández Rojas wrote:
> BCM63xx switches are present on bcm63xx and bmips devices.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>

Since you are targeting net-next, please make it clear in the patch
subject next time:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n28
--
Florian