2021-02-23 13:53:37

by Yang Li

Subject: [PATCH] mfd: lm3533: Switch to using the new API kobj_to_dev()

fixed the following coccicheck:
./drivers/mfd/lm3533-core.c:361:60-61: WARNING opportunity for
kobj_to_dev()

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/mfd/lm3533-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 22fdffd..5690768 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -358,7 +358,7 @@ static ssize_t store_output(struct device *dev,
static umode_t lm3533_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct lm3533 *lm3533 = dev_get_drvdata(dev);
struct device_attribute *dattr = to_dev_attr(attr);
struct lm3533_device_attribute *lattr = to_lm3533_dev_attr(dattr);
--
1.8.3.1

2021-03-09 14:47:34

by Lee Jones

Subject: Re: [PATCH] mfd: lm3533: Switch to using the new API kobj_to_dev()

On Tue, 23 Feb 2021, Yang Li wrote:

> fixed the following coccicheck:
> ./drivers/mfd/lm3533-core.c:361:60-61: WARNING opportunity for
> kobj_to_dev()
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/mfd/lm3533-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Fixed up the commit message a bit and applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog