2021-03-10 05:25:42

by Vasanth

Subject: [PATCH v2] drivers: hv: Fix EXPORT_SYMBOL and tab spaces issue

1.Fixed EXPORT_SYMBOL should be follow immediately function/variable.
2.Fixed code tab spaces issue.

Signed-off-by: Vasanth M <[email protected]>
---

changes in v2:
* Added commit message
* Revised Subject

drivers/hv/channel_mgmt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 1d44bb635bb8..84d6b3dde76f 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -302,7 +302,6 @@ bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp,
negop->icversion_data[1].minor = icmsg_minor;
return found_match;
}
-
EXPORT_SYMBOL_GPL(vmbus_prep_negotiate_resp);

/*
@@ -562,10 +561,10 @@ static void vmbus_process_offer(struct vmbus_channel *newchannel)
* CPUS_READ_UNLOCK CPUS_WRITE_UNLOCK
*
* Forbids: CPU1's LOAD from *not* seing CPU2's STORE &&
- * CPU2's SEARCH from *not* seeing CPU1's INSERT
+ * CPU2's SEARCH from *not* seeing CPU1's INSERT
*
* Forbids: CPU2's SEARCH from seeing CPU1's INSERT &&
- * CPU2's LOAD from *not* seing CPU1's STORE
+ * CPU2's LOAD from *not* seing CPU1's STORE
*/
cpus_read_lock();

@@ -928,7 +927,7 @@ static void vmbus_onoffer(struct vmbus_channel_message_header *hdr)
* UNLOCK channel_mutex
*
* Forbids: r1 == valid_relid &&
- * channels[valid_relid] == channel
+ * channels[valid_relid] == channel
*
* Note. r1 can be INVALID_RELID only for an hv_sock channel.
* None of the hv_sock channels which were present before the
--
2.25.1

2021-03-22 10:59:34

by Wei Liu

Subject: Re: [PATCH v2] drivers: hv: Fix EXPORT_SYMBOL and tab spaces issue

On Wed, Mar 10, 2021 at 10:51:55AM +0530, Vasanth wrote:
> 1.Fixed EXPORT_SYMBOL should be follow immediately function/variable.
> 2.Fixed code tab spaces issue.
>
> Signed-off-by: Vasanth M <[email protected]>

Applied to hyperv-next.