2021-03-10 07:50:58

by Yejune Deng

Subject: [PATCH] virt: acrn: Use EPOLLIN instead of POLLIN

This fixes the following sparse warning:
"sparse warnings: (new ones prefixed by >>)"
>> drivers/virt/acrn/irqfd.c:163:13: sparse: sparse: restricted __poll_t
degrades to integer

Fixes: 803c1aadecdb("virt: acrn: Use vfs_poll() instead of f_op->poll()")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Yejune Deng <[email protected]>
---
drivers/virt/acrn/irqfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
index 98d6e9b18f9e..df5184979b28 100644
--- a/drivers/virt/acrn/irqfd.c
+++ b/drivers/virt/acrn/irqfd.c
@@ -160,7 +160,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args)
/* Check the pending event in this stage */
events = vfs_poll(f.file, &irqfd->pt);

- if (events & POLLIN)
+ if (events & EPOLLIN)
acrn_irqfd_inject(irqfd);

fdput(f);
--
2.29.0

2021-03-10 08:10:51

by Shuo Liu

Subject: Re: [PATCH] virt: acrn: Use EPOLLIN instead of POLLIN

On Wed 10.Mar'21 at 15:49:01 +0800, Yejune Deng wrote:
>This fixes the following sparse warning:
>"sparse warnings: (new ones prefixed by >>)"
>>> drivers/virt/acrn/irqfd.c:163:13: sparse: sparse: restricted __poll_t
> degrades to integer
>
>Fixes: 803c1aadecdb("virt: acrn: Use vfs_poll() instead of f_op->poll()")
>Reported-by: kernel test robot <[email protected]>
>Signed-off-by: Yejune Deng <[email protected]>

Thanks for the patch.
Acked-by: Shuo Liu <[email protected]>

>---
> drivers/virt/acrn/irqfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
>index 98d6e9b18f9e..df5184979b28 100644
>--- a/drivers/virt/acrn/irqfd.c
>+++ b/drivers/virt/acrn/irqfd.c
>@@ -160,7 +160,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args)
> /* Check the pending event in this stage */
> events = vfs_poll(f.file, &irqfd->pt);
>
>- if (events & POLLIN)
>+ if (events & EPOLLIN)
> acrn_irqfd_inject(irqfd);
>
> fdput(f);
>--
>2.29.0
>