2021-03-10 09:24:15

by Jan Beulich

[permalink] [raw]
Subject: [PATCH] x86/vdso: avoid warning when building vdso2c on 32-bit host

size_t arguments can't compatibly be passed for l-modifier format
specifiers. Use z instead.

Fixes: 8382c668ce4f ("x86/vdso: Add support for exception fixup in vDSO functions")
Signed-off-by: Jan Beulich <[email protected]>

--- a/arch/x86/entry/vdso/vdso2c.h
+++ b/arch/x86/entry/vdso/vdso2c.h
@@ -35,7 +35,7 @@ static void BITSFUNC(extract)(const unsi
if (offset + len > data_len)
fail("section to extract overruns input data");

- fprintf(outfile, "static const unsigned char %s[%lu] = {", name, len);
+ fprintf(outfile, "static const unsigned char %s[%zu] = {", name, len);
BITSFUNC(copy)(outfile, data + offset, len);
fprintf(outfile, "\n};\n\n");
}


2021-03-10 11:29:04

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH] x86/vdso: avoid warning when building vdso2c on 32-bit host

On Wed, Mar 10, 2021 at 10:22:16AM +0100, Jan Beulich wrote:
> size_t arguments can't compatibly be passed for l-modifier format
> specifiers. Use z instead.
>
> Fixes: 8382c668ce4f ("x86/vdso: Add support for exception fixup in vDSO functions")
> Signed-off-by: Jan Beulich <[email protected]>
>
> --- a/arch/x86/entry/vdso/vdso2c.h
> +++ b/arch/x86/entry/vdso/vdso2c.h
> @@ -35,7 +35,7 @@ static void BITSFUNC(extract)(const unsi
> if (offset + len > data_len)
> fail("section to extract overruns input data");
>
> - fprintf(outfile, "static const unsigned char %s[%lu] = {", name, len);
> + fprintf(outfile, "static const unsigned char %s[%zu] = {", name, len);
> BITSFUNC(copy)(outfile, data + offset, len);
> fprintf(outfile, "\n};\n\n");

Already fixed:

https://git.kernel.org/tip/70c9d959226b7c5c48c119e2c1cfc1424f87b023

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette