2021-03-10 15:41:29

by Shuo Liu

[permalink] [raw]
Subject: [PATCH] virt: acrn: Fix document of acrn_msi_inject()

From: Shuo Liu <[email protected]>

This fixes below sparse warning.

../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

Fixes: c7cf8d27244f ("virt: acrn: Introduce interrupt injection interfaces")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Shuo Liu <[email protected]>
---
drivers/virt/acrn/vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/acrn/vm.c b/drivers/virt/acrn/vm.c
index 7804a2492ad7..0d002a355a93 100644
--- a/drivers/virt/acrn/vm.c
+++ b/drivers/virt/acrn/vm.c
@@ -94,7 +94,7 @@ int acrn_vm_destroy(struct acrn_vm *vm)
}

/**
- * acrn_inject_msi() - Inject a MSI interrupt into a User VM
+ * acrn_msi_inject() - Inject a MSI interrupt into a User VM
* @vm: User VM
* @msi_addr: The MSI address
* @msi_data: The MSI data
--
2.28.0


2021-03-10 15:52:29

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] virt: acrn: Fix document of acrn_msi_inject()

On Wed, Mar 10, 2021 at 11:37:51PM +0800, [email protected] wrote:
> From: Shuo Liu <[email protected]>
>
> This fixes below sparse warning.
>
> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

That is not a warning from sparse :(

2021-03-10 15:57:40

by Shuo Liu

[permalink] [raw]
Subject: Re: [PATCH] virt: acrn: Fix document of acrn_msi_inject()



On 3/10/2021 23:50, Greg Kroah-Hartman wrote:
> On Wed, Mar 10, 2021 at 11:37:51PM +0800, [email protected] wrote:
>> From: Shuo Liu <[email protected]>
>>
>> This fixes below sparse warning.
>>
>> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
>> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead
>
> That is not a warning from sparse :(
>

Oh. You are right. I was fixing another sparse warning and did
make O=out -j24 W=1 C=1
to reproduce that warning.

It misled me that this warning coming out with sparse too.

Let me re-send the patch.

Thanks
shuo