2021-03-10 16:08:29

by Shuo Liu

Subject: [PATCH v2] virt: acrn: Fix document of acrn_msi_inject()

This fixes below build warning.

../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

Fixes: c7cf8d27244f ("virt: acrn: Introduce interrupt injection interfaces")
Signed-off-by: Shuo Liu <[email protected]>
---
drivers/virt/acrn/vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/acrn/vm.c b/drivers/virt/acrn/vm.c
index 7804a2492ad7..0d002a355a93 100644
--- a/drivers/virt/acrn/vm.c
+++ b/drivers/virt/acrn/vm.c
@@ -94,7 +94,7 @@ int acrn_vm_destroy(struct acrn_vm *vm)
}

/**
- * acrn_inject_msi() - Inject a MSI interrupt into a User VM
+ * acrn_msi_inject() - Inject a MSI interrupt into a User VM
* @vm: User VM
* @msi_addr: The MSI address
* @msi_data: The MSI data
--
2.28.0

2021-03-10 17:30:31

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] virt: acrn: Fix document of acrn_msi_inject()

On Thu, Mar 11, 2021 at 12:05:38AM +0800, Shuo Liu wrote:
> This fixes below build warning.
>
> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

That's not a "normal" build warning is it? the compiler isn't spitting
it out...

Sorry to be a pain, but please be specific as to what is causing this to
show up...

thanks,

greg k-h

2021-03-11 01:56:10

by Shuo Liu

Subject: Re: [PATCH v2] virt: acrn: Fix document of acrn_msi_inject()

On Wed 10.Mar'21 at 18:27:53 +0100, Greg Kroah-Hartman wrote:
>On Thu, Mar 11, 2021 at 12:05:38AM +0800, Shuo Liu wrote:
>> This fixes below build warning.
>>
>> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
>> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead
>
>That's not a "normal" build warning is it? the compiler isn't spitting
>it out...
>
>Sorry to be a pain, but please be specific as to what is causing this to
>show up...

Sure. V3 is sent out.

Thanks
shuo