2021-03-11 07:28:53

by Hans Verkuil

[permalink] [raw]

Subject: Re: [PATCH v9 6/8] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

Hi Mirela,

On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:

<snip>

> +static const struct of_device_id mxc_jpeg_match[] = {
> + {
> + .compatible = "nxp,imx8qxp-jpgdec",
> + .data = (void *)MXC_JPEG_DECODE,

Don't do this, just say:

static const int mxc_decode_mode = MXC_JPEG_DECODE;
static const int mxc_encode_mode = MXC_JPEG_ENCODE;

and point to that:

.data = &mxc_decode_mode;

> + },
> + {
> + .compatible = "nxp,imx8qxp-jpgenc",
> + .data = (void *)MXC_JPEG_ENCODE,

.data = &mxc_encode_mode;

> + },
> + { },
> +};

<snip>

> +static int mxc_jpeg_probe(struct platform_device *pdev)
> +{
> + struct mxc_jpeg_dev *jpeg;
> + struct device *dev = &pdev->dev;
> + struct resource *res;
> + int dec_irq;
> + int ret;
> + int mode;
> + const struct of_device_id *of_id;
> + unsigned int slot;
> +
> + of_id = of_match_node(mxc_jpeg_match, dev->of_node);
> + mode = (int)(u64)of_id->data;

and this becomes:

mode = *(const int *)of_id->data;

This will solve the kernel test robot warning, and for that matter
the same gcc warnings I get when I compile.

Just post a v9.1 for this patch, everything else looks good.

Regards,

Hans

2021-03-11 09:16:23

by Mirela Rabulea

[permalink] [raw]

Subject: Re: [EXT] Re: [PATCH v9 6/8] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

On Thu, 2021-03-11 at 08:27 +0100, Hans Verkuil wrote:
> Caution: EXT Email
>
> Hi Mirela,
>
> On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
>
> <snip>
>
> > +static const struct of_device_id mxc_jpeg_match[] = {
> > + {
> > + .compatible = "nxp,imx8qxp-jpgdec",
> > + .data = (void *)MXC_JPEG_DECODE,
>
> Don't do this, just say:
>
> static const int mxc_decode_mode = MXC_JPEG_DECODE;
> static const int mxc_encode_mode = MXC_JPEG_ENCODE;
>
> and point to that:
>
> .data = &mxc_decode_mode;
>
> > + },
> > + {
> > + .compatible = "nxp,imx8qxp-jpgenc",
> > + .data = (void *)MXC_JPEG_ENCODE,
>
> .data = &mxc_encode_mode;
>
> > + },
> > + { },
> > +};
>
> <snip>
>
> > +static int mxc_jpeg_probe(struct platform_device *pdev)
> > +{
> > + struct mxc_jpeg_dev *jpeg;
> > + struct device *dev = &pdev->dev;
> > + struct resource *res;
> > + int dec_irq;
> > + int ret;
> > + int mode;
> > + const struct of_device_id *of_id;
> > + unsigned int slot;
> > +
> > + of_id = of_match_node(mxc_jpeg_match, dev->of_node);
> > + mode = (int)(u64)of_id->data;
>
> and this becomes:
>
> mode = *(const int *)of_id->data;
>
> This will solve the kernel test robot warning, and for that matter
> the same gcc warnings I get when I compile.

Hi Hans,
thanks for the suggestion, I missed that warning among the verbosity
from the other ones. Perhaps for the future it would be usefull for me
to try and replicate the kernel test robot environment.

I sent v9.1 just for this patch.

Regards,
Mirela

>
> Just post a v9.1 for this patch, everything else looks good.
>
> Regards,
>
> Hans

2021-03-11 11:03:26

by Hans Verkuil

[permalink] [raw]

Subject: Re: [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes

Hi Mirela,

On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea <[email protected]>
>
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.

FYI: I've posted a pull request for this driver, and once it is merged
in our media tree this patch can be merged for 5.13 by whoever handles
these dts patches.

Thank you for all your work on this!

Regards,

Hans

>
> Signed-off-by: Mirela Rabulea <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 1d522de7b017..4f2b3edd7850 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -629,4 +629,39 @@
> };
> };
> };
> +
> + img_subsys: bus@58000000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x58000000 0x0 0x58000000 0x1000000>;
> +
> + jpegdec: jpegdec@58400000 {
> + compatible = "nxp,imx8qxp-jpgdec";
> + reg = <0x58400000 0x00050000 >;
> + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
> + <&pd IMX_SC_R_MJPEG_DEC_S0>,
> + <&pd IMX_SC_R_MJPEG_DEC_S1>,
> + <&pd IMX_SC_R_MJPEG_DEC_S2>,
> + <&pd IMX_SC_R_MJPEG_DEC_S3>;
> + };
> +
> + jpegenc: jpegenc@58450000 {
> + compatible = "nxp,imx8qxp-jpgenc";
> + reg = <0x58450000 0x00050000 >;
> + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
> + <&pd IMX_SC_R_MJPEG_ENC_S0>,
> + <&pd IMX_SC_R_MJPEG_ENC_S1>,
> + <&pd IMX_SC_R_MJPEG_ENC_S2>,
> + <&pd IMX_SC_R_MJPEG_ENC_S3>;
> + };
> + };
> };
>

2021-03-12 10:39:58

by Aisheng Dong

[permalink] [raw]

Subject: RE: [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes

> From: Mirela Rabulea (OSS) <[email protected]>
> Sent: Thursday, March 11, 2021 8:29 AM
>
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.
>
> Signed-off-by: Mirela Rabulea <[email protected]>

Please rebase to latest shawn/for-next branch and add
the necessary clocks.
I can help review when resend.

Regards
Aisheng

> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 35
> ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 1d522de7b017..4f2b3edd7850 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -629,4 +629,39 @@
> };
> };
> };
> +
> + img_subsys: bus@58000000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x58000000 0x0 0x58000000 0x1000000>;
> +
> + jpegdec: jpegdec@58400000 {
> + compatible = "nxp,imx8qxp-jpgdec";
> + reg = <0x58400000 0x00050000 >;
> + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
> + <&pd IMX_SC_R_MJPEG_DEC_S0>,
> + <&pd IMX_SC_R_MJPEG_DEC_S1>,
> + <&pd IMX_SC_R_MJPEG_DEC_S2>,
> + <&pd IMX_SC_R_MJPEG_DEC_S3>;
> + };
> +
> + jpegenc: jpegenc@58450000 {
> + compatible = "nxp,imx8qxp-jpgenc";
> + reg = <0x58450000 0x00050000 >;
> + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
> + <&pd IMX_SC_R_MJPEG_ENC_S0>,
> + <&pd IMX_SC_R_MJPEG_ENC_S1>,
> + <&pd IMX_SC_R_MJPEG_ENC_S2>,
> + <&pd IMX_SC_R_MJPEG_ENC_S3>;
> + };
> + };
> };
> --
> 2.17.1