2021-03-12 03:27:04

by Chris Chiu

[permalink] [raw]
Subject: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

From: Chris Chiu <[email protected]>

The .callback of the quirk for Sony VPCEH3U1E was unintetionally
removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
for Sony VPCEH3U1E works as expected.

Signed-off-by: Chris Chiu <[email protected]>
Reported-by: Pavel Machek <[email protected]>
---
drivers/acpi/video_detect.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 811d298637cb..83cd4c95faf0 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -147,6 +147,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
},
},
{
+ .callback = video_detect_force_vendor,
.ident = "Sony VPCEH3U1E",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
--
2.20.1


2021-03-13 10:45:47

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

On Fri 2021-03-12 11:24:30, [email protected] wrote:
> From: Chris Chiu <[email protected]>
>
> The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> for Sony VPCEH3U1E works as expected.
>
> Signed-off-by: Chris Chiu <[email protected]>
> Reported-by: Pavel Machek <[email protected]>

Thanks for doing this.

Reviewed-by: Pavel Machek (CIP) <[email protected]>

Best regards, Pavel
--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (610.00 B)
signature.asc (201.00 B)
Download all attachments

2021-03-19 16:48:21

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <[email protected]> wrote:
>
> On Fri 2021-03-12 11:24:30, [email protected] wrote:
> > From: Chris Chiu <[email protected]>
> >
> > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > for Sony VPCEH3U1E works as expected.
> >
> > Signed-off-by: Chris Chiu <[email protected]>
> > Reported-by: Pavel Machek <[email protected]>
>
> Thanks for doing this.
>
> Reviewed-by: Pavel Machek (CIP) <[email protected]>

Applied as 5.12-rc5 material, thanks!

2021-03-19 18:52:05

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

On Fri 2021-03-19 17:44:32, Rafael J. Wysocki wrote:
> On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <[email protected]> wrote:
> >
> > On Fri 2021-03-12 11:24:30, [email protected] wrote:
> > > From: Chris Chiu <[email protected]>
> > >
> > > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > > for Sony VPCEH3U1E works as expected.
> > >
> > > Signed-off-by: Chris Chiu <[email protected]>
> > > Reported-by: Pavel Machek <[email protected]>
> >
> > Thanks for doing this.
> >
> > Reviewed-by: Pavel Machek (CIP) <[email protected]>
>
> Applied as 5.12-rc5 material, thanks!

Commit 25417185e9b5 made it into stable, so this one should be Cc:
stable as well. Sorry for noticing that late.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (958.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments

2021-03-19 18:55:36

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

On Fri, Mar 19, 2021 at 7:48 PM Pavel Machek <[email protected]> wrote:
>
> On Fri 2021-03-19 17:44:32, Rafael J. Wysocki wrote:
> > On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek <[email protected]> wrote:
> > >
> > > On Fri 2021-03-12 11:24:30, [email protected] wrote:
> > > > From: Chris Chiu <[email protected]>
> > > >
> > > > The .callback of the quirk for Sony VPCEH3U1E was unintetionally
> > > > removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk
> > > > for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk
> > > > for Sony VPCEH3U1E works as expected.
> > > >
> > > > Signed-off-by: Chris Chiu <[email protected]>
> > > > Reported-by: Pavel Machek <[email protected]>
> > >
> > > Thanks for doing this.
> > >
> > > Reviewed-by: Pavel Machek (CIP) <[email protected]>
> >
> > Applied as 5.12-rc5 material, thanks!
>
> Commit 25417185e9b5 made it into stable, so this one should be Cc:
> stable as well. Sorry for noticing that late.

Well, do you know which -stable series it went into?

I've added a "Cc: stable" tag to this one, but it most likely doesn't
cover all of them.