2021-03-13 10:53:43

by Menglong Dong

Subject: [PATCH] crash_dump: remove duplicate include in crash_dump.h

From: Zhang Yunkai <[email protected]>

'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
It is also included in the 8th line.

Signed-off-by: Zhang Yunkai <[email protected]>
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b718dbe..6bd8a33cb740 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>

-#include <linux/pgtable.h> /* for pgprot_t */
-
#ifdef CONFIG_CRASH_DUMP
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.25.1

2021-03-19 12:40:30

by Baoquan He

Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h

On 03/13/21 at 02:35am, [email protected] wrote:
> From: Zhang Yunkai <[email protected]>
>
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> It is also included in the 8th line.

Tian Tao posted one to address the same issue, his log is better. Please
update with below to repost.

linux/pgtable.h is included more than once, Remove the one that isn't
necessary.

>
> Signed-off-by: Zhang Yunkai <[email protected]>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..6bd8a33cb740 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>
>
> _______________________________________________
> kexec mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/kexec
>