2021-03-13 10:55:17

by Sergei Trofimovich

Subject: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq

Fix warning with %lx / s64 mismatch:

CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o
drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
warning: format '%lx' expects argument of type 'long unsigned int',
but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]

CC: "Rafael J. Wysocki" <[email protected]>
CC: Viresh Kumar <[email protected]>
CC: [email protected]
Signed-off-by: Sergei Trofimovich <[email protected]>
---
drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
index 2efe7189ccc4..c6bdc455517f 100644
--- a/drivers/cpufreq/ia64-acpi-cpufreq.c
+++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
@@ -54,7 +54,7 @@ processor_set_pstate (
retval = ia64_pal_set_pstate((u64)value);

if (retval) {
- pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
+ pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n",
value, retval);
return -ENODEV;
}
@@ -77,7 +77,7 @@ processor_get_pstate (

if (retval)
pr_debug("Failed to get current freq with "
- "error 0x%lx, idx 0x%x\n", retval, *value);
+ "error 0x%llx, idx 0x%x\n", retval, *value);

return (int)retval;
}
--
2.30.2

2021-03-15 03:21:18

by Viresh Kumar

Subject: Re: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq

On 13-03-21, 10:42, Sergei Trofimovich wrote:
> Fix warning with %lx / s64 mismatch:
>
> CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o
> drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
> warning: format '%lx' expects argument of type 'long unsigned int',
> but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]
>
> CC: "Rafael J. Wysocki" <[email protected]>
> CC: Viresh Kumar <[email protected]>
> CC: [email protected]
> Signed-off-by: Sergei Trofimovich <[email protected]>
> ---
> drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index 2efe7189ccc4..c6bdc455517f 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -54,7 +54,7 @@ processor_set_pstate (
> retval = ia64_pal_set_pstate((u64)value);
>
> if (retval) {
> - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
> + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n",
> value, retval);
> return -ENODEV;
> }
> @@ -77,7 +77,7 @@ processor_get_pstate (
>
> if (retval)
> pr_debug("Failed to get current freq with "
> - "error 0x%lx, idx 0x%x\n", retval, *value);
> + "error 0x%llx, idx 0x%x\n", retval, *value);
>
> return (int)retval;
> }

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2021-03-19 16:29:58

by Rafael J. Wysocki

Subject: Re: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq

On Mon, Mar 15, 2021 at 4:19 AM Viresh Kumar <[email protected]> wrote:
>
> On 13-03-21, 10:42, Sergei Trofimovich wrote:
> > Fix warning with %lx / s64 mismatch:
> >
> > CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o
> > drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
> > warning: format '%lx' expects argument of type 'long unsigned int',
> > but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]
> >
> > CC: "Rafael J. Wysocki" <[email protected]>
> > CC: Viresh Kumar <[email protected]>
> > CC: [email protected]
> > Signed-off-by: Sergei Trofimovich <[email protected]>
> > ---
> > drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> > index 2efe7189ccc4..c6bdc455517f 100644
> > --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> > +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> > @@ -54,7 +54,7 @@ processor_set_pstate (
> > retval = ia64_pal_set_pstate((u64)value);
> >
> > if (retval) {
> > - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
> > + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n",
> > value, retval);
> > return -ENODEV;
> > }
> > @@ -77,7 +77,7 @@ processor_get_pstate (
> >
> > if (retval)
> > pr_debug("Failed to get current freq with "
> > - "error 0x%lx, idx 0x%x\n", retval, *value);
> > + "error 0x%llx, idx 0x%x\n", retval, *value);
> >
> > return (int)retval;
> > }
>
> Acked-by: Viresh Kumar <[email protected]>

Applied as 5.13 material, thanks!