2021-03-15 07:30:50

by zhaoxiao

[permalink] [raw]
Subject: [PATCH] staging: rtl8192u: remove extra lines

Remove extra lines in many functions in r8192U_wx.c.
Signed-off-by: zhaoxiao <[email protected]>
---
drivers/staging/rtl8192u/r8192U_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e68d37914456 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -879,7 +879,6 @@ static iw_handler r8192_wx_handlers[] = {


static const struct iw_priv_args r8192_private_args[] = {
-
{
SIOCIWFIRSTPRIV + 0x0,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
@@ -890,14 +889,15 @@ static const struct iw_priv_args r8192_private_args[] = {
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"

},
+
{
SIOCIWFIRSTPRIV + 0x2,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "rawtx"
},
+
{
SIOCIWFIRSTPRIV + 0x3,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
-
}

};
--
2.20.1




2021-03-15 07:58:00

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8192u: remove extra lines

On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote:
> Remove extra lines in many functions in r8192U_wx.c.
> Signed-off-by: zhaoxiao <[email protected]>

You did mor than just remove extra lines :(

Also we need an extra line right before your signed-off-by line, as
checkpatch should have warned you about.

Please fix up and resend.

thanks,

greg k-h