2021-03-16 10:06:46

by Jeremy Szu

Subject: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8

The HP EliteBook 850 G8 Notebook PC is using ALC285 codec which is
using 0x04 to control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.

Signed-off-by: Jeremy Szu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e34ba64dd0ae..8239e5efc12d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8067,6 +8067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+ SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
--
2.30.1

2021-03-16 16:19:38

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8

On Tue, 16 Mar 2021 10:42:35 +0100,
Jeremy Szu wrote:
>
> The HP EliteBook 850 G8 Notebook PC is using ALC285 codec which is
> using 0x04 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <[email protected]>

Applied now.

But at the next time, if you submit multiple similar patches, please
try to submit in a patch series. It'll make review easier.


thanks,

Takashi