2021-03-16 20:27:31

by Geert Uytterhoeven

Subject: [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB

The Broadcom STB RESCAL reset controller is only present on Broadcom
BCM7216 platforms. Hence add a dependency on ARCH_BRCMSTB, to prevent
asking the user about this driver when configuring a kernel without
BCM7216 support.

Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
code, and thus should not enable this driver by default.

Fixes: 4cf176e52397853e ("reset: Add Broadcom STB RESCAL reset controller")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/reset/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 4171c6f763858a03..6dba675bcec47777 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -59,7 +59,8 @@ config RESET_BRCMSTB
config RESET_BRCMSTB_RESCAL
bool "Broadcom STB RESCAL reset controller"
depends on HAS_IOMEM
- default ARCH_BRCMSTB || COMPILE_TEST
+ depends on ARCH_BRCMSTB || COMPILE_TEST
+ default ARCH_BRCMSTB
help
This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
BCM7216.
--
2.25.1

2021-03-16 20:53:32

by Florian Fainelli

Subject: Re: [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB

On 3/16/2021 6:37 AM, Geert Uytterhoeven wrote:
> The Broadcom STB RESCAL reset controller is only present on Broadcom
> BCM7216 platforms. Hence add a dependency on ARCH_BRCMSTB, to prevent
> asking the user about this driver when configuring a kernel without
> BCM7216 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Fixes: 4cf176e52397853e ("reset: Add Broadcom STB RESCAL reset controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian